Fit describe-code metadata on training split only - #167
Draft
florian6973 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
data/train/**/*.parquetfor split-sharded MEDS datasetsmetadata/subject_splits.parquetWhy
meds-tab-describerecursively scanned all Parquet files underinput_dir. On split-sharded datasets, tuning and held-out covariates therefore influencedmetadata/codes.parquetand downstream feature filtering such asmin_code_inclusion_count.This is label-free held-out preprocessing leakage: evaluation covariates could affect the fitted feature vocabulary even though labels were not used.
Impact
Preprocessing metadata is now fitted only on training subjects and then reused for all splits. A code with 8 train occurrences and 5 held-out occurrences now has fitted count 8 and will not pass a minimum count of 10.
Validation
uv run pytest -q: 82 passedgit diff --checkpassedFixes #166