fix(otel): fix concurrency bug in TracingHook span tracking#492
Draft
simonvdk-mistral wants to merge 2 commits intomainfrom
Draft
fix(otel): fix concurrency bug in TracingHook span tracking#492simonvdk-mistral wants to merge 2 commits intomainfrom
simonvdk-mistral wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
TracingHookstored the active span asself.request_span— a single instance attribute shared across all concurrent requests. When two requests were in-flight simultaneously, they clobbered each other's span:Impact: spans attributed to wrong requests, spans never closed (leaked), response attributes applied to wrong traces.
Reproducing
The test
test_concurrent_async_requests_get_correct_spansreproduces this using a realMistralclient withasyncio.gatherand a mock transport. Anasyncio.Eventgate ensures bothbefore_requesthooks fire before either response returns, guaranteeing the interleaving.Fix
Store the span on
request.extensions["_tracing_span"]instead ofself.request_span. Retrieve it inafter_success/after_errorviaresponse.request.extensions. This is the sameextensionsdict that httpx uses internally (e.g. for timeouts) — it is purely in-memory metadata, never serialized or sent over the wire.Note: no other hook had this bug —
TracingHookwas the only one storing per-request state onself.