Repository navigation
Production E2E: expect shared artifact records from the operator console - #1871
Merged
Merged
Conversation
…red records #1866 made the operator console cache issued merchant artifacts without a buyer, so the public catalog and every buyer read them, and updated the unit test. The production regression spec still expected the buyer on the cache call; it went unnoticed while every post-deploy run aborted at load. It now expects shared records (artifacts, no buyer), and the buyer's ask still carries the buyer.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The production E2E after the 61f6806 release ran 728 tests: 727 passed and one failed. The failing test is
commerce-runtime-demo.spec.ts:250, which gotExpected: "buyer_agent_demo",Received: undefinedon the artifact cache call.CommerceRuntimeDemo.test.tsx, but missed this production regression spec.What changes
The spec now expects the cache call to carry artifacts and no buyer. The buyer's
askcall still carriesbuyer_agent_demowithnon_binding_preview.Tests
The spec was run against the production UI. Its API calls are mocked by the spec.
Expected/Receivedas the production run.