Skip to content

fix: average calculation on conflict #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonprev merged 1 commit into from
Jun 12, 2026
Merged

fix: average calculation on conflict #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/telemetry_ui/backend/ecto_postgres.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ defmodule TelemetryUI.Backend.EctoPostgres do
DO UPDATE SET
max_value = GREATEST(telemetry_ui_events.max_value, EXCLUDED.value),
min_value = LEAST(telemetry_ui_events.min_value, EXCLUDED.value),
value = ROUND((telemetry_ui_events.value + EXCLUDED.value)::numeric / 2, 4),
value = ROUND(((telemetry_ui_events.value * telemetry_ui_events.count) + (EXCLUDED.value * EXCLUDED.count))::numeric / (telemetry_ui_events.count + EXCLUDED.count), 4),
count = telemetry_ui_events.count + EXCLUDED.count
""",
[entry.value, entry.date, entry.name, entry.tags, entry.count, entry.min_value, entry.max_value],
Expand Down
4 changes: 2 additions & 2 deletions test/telemetry_ui/ecto_postgres_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ defmodule TelemetryUI.EctoPostgresTest do

[event] = backend.repo.all(Entry)

assert event.value === 15.0
assert event.value === 16.6667
assert event.tags === %{}
assert event.count === 6
assert event.date === ~U[2022-02-10T00:00:00Z]
Expand Down Expand Up @@ -136,7 +136,7 @@ defmodule TelemetryUI.EctoPostgresTest do

[event] = backend.repo.all(Entry)

assert event.value === 15.0
assert event.value === 16.6667
assert event.min_value === 10.0
assert event.max_value === 20.0
assert event.tags === %{}
Expand Down
Loading