Update for for cosign v3, regularize inputs and outputs - #4
Conversation
|
(Note that this won't work until mindersec/minder-client-installer#3 is merged, and |
|
Renaming minder_version -> release, rules_directory -> rules-directory, and install_dir -> install-dir are breaking changes for existing users. Could we note this in the PR description and README, and consider whether a deprecation warning or alias is needed? |
krrish175-byte
left a comment
krrish175-byte
left a comment
There was a problem hiding this comment.
Solid direction overall, but there are a few issues worth addressing.
| value: ${{ steps.upload-results.outputs.artifact-url }} | ||
| junit-artifact-digest: | ||
| description: SHA-256 digest of the JUnit XML result. | ||
| value: ${{ steps.upload-results.outputs.artifact-url }} |
There was a problem hiding this comment.
This copies artifact-url again instead of artifact-digest. Should be: value: ${{ steps.upload-results.outputs.artifact-digest }}
There was a problem hiding this comment.
Too much autocomplete, thanks!
| description: SHA-256 digest of the JUnit XML result. | ||
| value: ${{ steps.upload-results.outputs.artifact-url }} | ||
| junit-filename: | ||
| description: Filesystem path to the JUnixt XML result. |
There was a problem hiding this comment.
Typo: "JUnixt" -> "JUnit"
01c97ce to
fafc741
Compare
2 participants
A few changes:
minder-actionandminder-action/testwhere possible.minder-client-installer(after Update minder-client-installer for latest release with cosign v3 minder-client-installer#3) v1.1.0 actions release.minderrelease to a specific version (the current latest) by default, to assist people who are trying to not have their infrastructure move out from under them.minder-action/test, and outputting some data about where the test results exist.