Skip to content

fix(ci): pull MinIO from Quay - #610

Merged
shanghaikid merged 1 commit into
mainfrom
fix/ci-minio-quay
Sep 16, 2026
Merged

shanghaikid merged 1 commit into
mainfrom
fix/ci-minio-quay

Conversation

@shanghaikid

Copy link
Copy Markdown
Contributor

The test workflow fails before running tests because Docker Hub denies pulling minio/minio:RELEASE.2024-05-28T17-19-04Z, as seen in the CI run for #609.

Override MinIO with the same release from quay.io/minio/minio. Remove the .github/** path exclusion from pull request and push triggers so workflow-only fixes receive CI coverage.

Validation:

  • Prettier formatting and git diff --check passed.
  • docker compose config --images with the upstream Compose file and the workflow override resolves MinIO to the Quay image.
  • The Quay manifest endpoint returns HTTP 200 and identifies an amd64 image.
  • Full image pull and integration tests are left to CI.

This is a separate CI fix; it does not include the documentation changes in #609.

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: jiangruiyi@gmail.com <jiangruiyi@gmail.com>
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.82%. Comparing base (6b7ae07) to head (eb600fd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          68       68           
  Lines        6924     6924           
  Branches     2016     2016           
=======================================
  Hits         6704     6704           
  Misses        212      212           
  Partials        8        8           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shanghaikid
shanghaikid merged commit 85e071f into main Sep 16, 2026
4 of 5 checks passed
@shanghaikid
shanghaikid deleted the fix/ci-minio-quay branch September 16, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants