Repository navigation
fix: upgrade browserslist to address Dependabot alert 475 - #607
Merged
Merged
Conversation
Signed-off-by: ryjiang <jiangruiyi@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanghaikid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 68 68
Lines 6924 6924
Branches 2016 2016
=======================================
Hits 6704 6704
Misses 212 212
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browserslist 4.24.2, pulled in by Jest/Babel, can crash on crafted custom statistics containing inherited property names (GHSA-73wf-gq98-2v4g). Add a
browserslist: ^4.28.7resolution and update the root lockfile to 4.28.9, including its required dependencies.Addresses Dependabot alert #475.
Validation:
npm run buildpasses.NODE_ENV=dev npx jest test/utils/Validate.spec.ts --runInBand: 37 tests pass.git diff --checkpass.Also reviewed alerts #473 and #462. Their affected APIs are not used by the current MinIO dependency: MinIO uses the JSONL parser rather than stream-json path filters, and query-string encoding rather than decoding. Direct overrides to the patched versions introduce API/module incompatibilities with the current MinIO dependency chain. Those alerts remain open and are not addressed by this PR.