Conversation
… values as static Closes #1785 Co-Authored-By: aiden@million.dev <aiden.bai05@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
Original prompt from Aiden
|
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1785.
contentContainerStyle={{ paddingTop: ListHeaderComponent ? 0 : 16 }}was reported as "changing padding" even though both outcomes are design-time constants; the rule exists for values that track a runtime measurement (keyboardHeight,insets.bottom) and reflow the list every time they move.isStaticStyleValuenow accepts aConditionalExpressionwhen both branches are themselves static (recursing with the existing depth budget, so nested ternaries and const-bound branches work):This is not a prop-based blanket exemption:
isKeyboardOpen ? keyboardHeight : 0,hasTabBar ? 0 : insets.bottom, and two-dynamic-branch ternaries all still report (covered by new tests, alongside the exactFlashListrepro, static-const branches, and a nested static ternary).Also reworded the recommendation: the old text (
contentInset={{ bottom: dynamicValue }}) implied a cross-platform drop-in that also covered the top edge. It now says to move the changing value to the matchingcontentInsetedge, notes thatcontentInsetis iOS-only, and to keep static spacing incontentContainerStyle.core-rule-registry-data.jsonis regenerated for that string. Changeset added foroxlint-plugin-react-doctor.Supersedes the auto-triage draft #1789.
Link to Devin session: https://app.devin.ai/sessions/3401e96268dc4245bf9a058d631ccc36
Open in Devin Desktop: https://app.devin.ai/desktop/session/3401e96268dc4245bf9a058d631ccc36?variant=devin
Requested by: @aidenybai