Skip to content

fix(cargo-wdk): disable Cargo build-dir v2 layout via environment variable - #708

Draft
svasista-ms wants to merge 1 commit into
microsoft:mainfrom
svasista-ms:fix/cargo-wdk-build-dir-v2-opt-out
Draft

fix(cargo-wdk): disable Cargo build-dir v2 layout via environment variable#708
svasista-ms wants to merge 1 commit into
microsoft:mainfrom
svasista-ms:fix/cargo-wdk-build-dir-v2-opt-out

Conversation

@svasista-ms

Copy link
Copy Markdown
Contributor

TBD

Copilot AI review requested due to automatic review settings August 3, 2026 13:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cargo-wdk’s build flow to explicitly disable Cargo’s “build-dir v2 / new target-dir layout” via an environment variable during cargo build, ensuring cargo-wdk continues to observe the expected output layout.

Changes:

  • Passes CARGO_UNSTABLE_BUILD_DIR_NEW_LAYOUT=false into the cargo build invocation from BuildTask.
  • Adds a dedicated unit test asserting the environment variable is forwarded to the command executor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.86%. Comparing base (66223e9) to head (02c34ca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   80.47%   75.86%   -4.62%     
==========================================
  Files          26       31       +5     
  Lines        5722     6174     +452     
  Branches     5722     6174     +452     
==========================================
+ Hits         4605     4684      +79     
- Misses        989     1354     +365     
- Partials      128      136       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants