fix(cargo-wdk): disable Cargo build-dir v2 layout via environment variable - #708
Draft
svasista-ms wants to merge 1 commit into
Draft
fix(cargo-wdk): disable Cargo build-dir v2 layout via environment variable#708svasista-ms wants to merge 1 commit into
svasista-ms wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates cargo-wdk’s build flow to explicitly disable Cargo’s “build-dir v2 / new target-dir layout” via an environment variable during cargo build, ensuring cargo-wdk continues to observe the expected output layout.
Changes:
- Passes
CARGO_UNSTABLE_BUILD_DIR_NEW_LAYOUT=falseinto thecargo buildinvocation fromBuildTask. - Adds a dedicated unit test asserting the environment variable is forwarded to the command executor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 80.47% 75.86% -4.62%
==========================================
Files 26 31 +5
Lines 5722 6174 +452
Branches 5722 6174 +452
==========================================
+ Hits 4605 4684 +79
- Misses 989 1354 +365
- Partials 128 136 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD