feat: add --inf2cat-args passthrough to customize inf2cat options - #702
Draft
svasista-ms wants to merge 4 commits into
Draft
feat: add --inf2cat-args passthrough to customize inf2cat options#702svasista-ms wants to merge 4 commits into
--inf2cat-args passthrough to customize inf2cat options#702svasista-ms wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new cargo wdk build CLI option (--inf2cat-args) to forward user-supplied arguments to inf2cat during catalog generation, threading those arguments through the build/package action pipeline and documenting the behavior.
Changes:
- Added
--inf2cat-argsto the build CLI, including parsing/tokenization logic and unit tests. - Plumbed
inf2cat_argsthroughBuildActionParams→PackageTaskParamsand updatedinf2catinvocation to either use defaults or forward caller-provided switches. - Updated build/package tests and the
cargo-wdkREADME to mention the new option.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/cargo-wdk/src/cli.rs | Adds --inf2cat-args, tokenization parser, and CLI plumbing into BuildActionParams; adds unit tests. |
| crates/cargo-wdk/src/actions/build/mod.rs | Adds inf2cat_args to build action params/state and forwards into packaging. |
| crates/cargo-wdk/src/actions/build/package_task.rs | Stores forwarded inf2cat_args and changes inf2cat argument construction behavior; adds tests. |
| crates/cargo-wdk/src/actions/build/tests.rs | Updates build action test initialization for the new parameter. |
| crates/cargo-wdk/README.md | Documents the new CLI flag and describes inf2cat customization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 80.47% 81.14% +0.66%
==========================================
Files 26 26
Lines 5722 5923 +201
Branches 5722 5923 +201
==========================================
+ Hits 4605 4806 +201
Misses 989 989
Partials 128 128 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
docs: use better example for `inf2cat-args` usage
…versions # Conflicts: # crates/cargo-wdk/src/actions/build/mod.rs # crates/cargo-wdk/src/actions/build/package_task.rs # crates/cargo-wdk/src/cli.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--inf2cat-argspassthrough tocargo wdk buildso users can customize the options forwarded toinf2cat(e.g. target OS versions) instead of being locked to the built-in defaults.NOTE: cargo-wdk always supplies /driver:; a user-supplied /driver: / /drv: switch is rejected at parse time, as are unterminated quotes.
Resolves #91
Screenshots
inf2cat-argsresult in the same args being passed: