feat(cargo-wdk): add `--signtool-args` passthrough to customize driver signing by svasista-ms · Pull Request #699 · microsoft/windows-drivers-rs

svasista-ms · 2026-07-07T11:13:52Z

Adds --signtool-args passthrough so driver signing can be customized (certificate selection, digest algorithm, timestamping, extra file operands).

When --signtool-args is omitted, cargo-wdk signs with the auto-generated WDR test certificate and default switches.
When --signtool-args is provided, the caller owns the full signtool sign option set except the sign verb and the trailing file operand (spplied by cargo-wdk). Supplying it with --sign-mode=off is rejected.

⚠️ Behavior change

Packaging removes any existing <target>/<profile>/<name>_package folder at the start of each build and recreates it, so stale signing artifacts (e.g. a WDRLocalTestCert.cer from a previous --sign-mode=test build) don't persist across rebuilds.

Screenshots

Resolves #605

…te selection

…separate module

Copilot

Pull request overview

Adds a cargo wdk build --signtool-args passthrough so driver signing can be customized (certificate selection, digest, timestamping, extra operands), and adjusts packaging to stage artifacts in a fresh directory and assemble the final package folder last—preventing stale signing artifacts from persisting across rebuilds.

Changes:

Add --signtool-args to the CLI and plumb it through to signtool sign invocation.
Rework packaging to build in a clean per-build staging directory and rename into the final package folder at the end (fixes stale cert artifact scenarios).
Expand integration/unit tests and documentation to cover the new signing behavior and staging semantics.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
crates/cargo-wdk/tests/build_command_test.rs	Adds regression + functional integration tests for staging behavior and `--signtool-args`.
crates/cargo-wdk/src/providers/mod.rs	Extends filesystem error enum to cover directory removal failures.
crates/cargo-wdk/src/providers/fs.rs	Adds `remove_dir_all` wrapper to the FS provider for testable directory cleanup.
crates/cargo-wdk/src/cli.rs	Introduces `--signtool-args` and validates signing flag combinations via `TryFrom<&BuildArgs> for SignMode`.
crates/cargo-wdk/src/actions/build/tests.rs	Updates build action unit test expectations for staging-dir + final assembly flow and new `SignMode` shape.
crates/cargo-wdk/src/actions/build/package_task.rs	Implements staging directory flow, package folder assembly, signtool argument tokenization + passthrough, and updates signing behavior.
crates/cargo-wdk/src/actions/build/mod.rs	Adjusts `BuildAction` to clone `SignMode` (now contains owned data).
crates/cargo-wdk/README.md	Documents `--signtool-args`, quoting/tokenization rules, and updated signing/staging semantics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov-commenter · 2026-07-07T11:45:46Z

Codecov Report

❌ Patch coverage is 96.45833% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.66%. Comparing base (66223e9) to head (8139c0c).

Files with missing lines	Patch %	Lines
crates/cargo-wdk/src/actions/new/mod.rs	50.00%	7 Missing ⚠️
crates/cargo-wdk/src/actions/build/package_task.rs	98.44%	0 Missing and 4 partials ⚠️
crates/cargo-wdk/src/actions/build/mod.rs	84.21%	2 Missing and 1 partial ⚠️
crates/cargo-wdk/src/cli.rs	98.57%	1 Missing and 1 partial ⚠️
crates/cargo-wdk/src/providers/fs.rs	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   80.47%   81.66%   +1.18%     
==========================================
  Files          26       25       -1     
  Lines        5722     6107     +385     
  Branches     5722     6107     +385     
==========================================
+ Hits         4605     4987     +382     
  Misses        989      989              
- Partials      128      131       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…kaging process

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

krishnakumar4a4 · 2026-07-14T13:03:18Z

+
+/// Builds a `clap::Error` with the given message, rendered with the standard
+/// `cargo wdk build` usage for a consistent CLI experience.
+fn build_error(message: impl std::fmt::Display) -> clap::Error {


nit: we could inline this at call site, no need of a separate function

Yes, it was inline initially. But I added the function because ArgumentConflict error can be constructed from multiple places (2 in try_from for SignMode). Once args for all tools are added we could use anyhow to construct CLI errors.

Move build_error into the function in which it is used and declare it as a nested function. That is a good pattern to follow whenever you need a function that is used only inside one function.

krishnakumar4a4 · 2026-07-14T13:08:43Z

+
+/// Arguments to `signtool sign` for signing the driver binary and catalog file.
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub struct SigntoolArgs(pub Vec<String>);


Move this declaration to the top to keep all arg type declarations at one place.

krishnakumar4a4 · 2026-07-14T13:15:25Z

+            .expect("args parse");
+        let err = SignMode::try_from(&args).expect_err("should be rejected");
+        assert!(
+            err.to_string().contains("`--sign-mode=off`"),


use the exact message for assertion

`--signtool-args` cannot be used with `--sign-mode=off`.

Can we not match exactly and avoid using contains?

Fixed ✅, using the full message for assertion 👍

krishnakumar4a4 · 2026-07-14T13:19:17Z

+    }
+
+    #[test]
+    fn build_off_mode_maps_to_off() {


Suggested change

fn build_off_mode_maps_to_off() {

fn build_sign_mode_off_maps_correctly() {

krishnakumar4a4 · 2026-07-14T13:23:21Z

+        let err = parse_build_args(&["--signtool-args", "/n \"CN=Contoso"])
+            .expect_err("unterminated quote should be rejected");
+        assert!(
+            err.to_string().contains("unterminated"),


Try and use exact message assertion

Similar suggestion as this: https://github.com/microsoft/windows-drivers-rs/pull/699/changes#r3579259207

krishnakumar4a4 · 2026-07-14T13:25:12Z

+    }
+
+    #[test]
+    fn build_signtool_args_with_verify_signature_maps_both() {


Suggested change

fn build_signtool_args_with_verify_signature_maps_both() {

fn build_verify_signature_works_with_signtool_args() {

krishnakumar4a4 · 2026-07-14T13:29:20Z

@@ -304,25 +402,119 @@ mod tests {

    #[test]
    fn build_rejects_verify_signature_when_sign_mode_is_off() {


As we have multiple tests for build sub command, We should move all the build tests to a submodule here and avoid using build as prefix for each test.

Done ✅ , moved to a separate mod

…tion

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

…rify`

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

crates/cargo-wdk/tests/build_command_test.rs:653

ensure_cert_in_store hard-asserts that certmgr.exe -s <store> succeeds. For a custom store (e.g. WDRCustomTestStore), that query can fail if the store doesn’t exist yet, which makes these functional tests unnecessarily flaky. The production code path treats a non-success certmgr status as “cert not found” and proceeds to makecert; this helper should do the same.

        let output = Command::new("certmgr.exe")
            .args(["-s", store])
            .output()
            .expect("failed to query certificate store");
        assert!(output.status.success(), "certmgr query failed for {store}");

crates/cargo-wdk/README.md:160

The README example recommends passing a PFX password inline via /p <password>. Even with redaction in cargo-wdk logs, command-line arguments are often exposed via process listings and shell history. Add an explicit warning here so users don’t accidentally leak secrets when copy/pasting this example.

- To test-sign with a PFX file whose password is supplied inline, run:

gurry · 2026-07-29T11:44:26Z

+
+/// Builds a `clap::Error` with the given message, rendered with the standard
+/// `cargo wdk build` usage for a consistent CLI experience.
+fn build_error(message: impl std::fmt::Display) -> clap::Error {


Move build_error into the function in which it is used and declare it as a nested function. That is a good pattern to follow whenever you need a function that is used only inside one function.

…sign_mode` and drop qualified `Result/Ok` paths

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

crates/cargo-wdk/src/actions/build/package_task.rs:560

Redaction index calculation can incorrectly redact the final file operand when the caller passes /p without a password value (e.g. --signtool-args '/p'). Since the package code appends the file path as the last argument, the current i + 1 < arg_refs.len() condition treats that file operand as the password value and hides it in logs/errors, making failures harder to diagnose.

            .filter_map(|(i, arg)| {
                (arg.eq_ignore_ascii_case("/p") && i + 1 < arg_refs.len()).then_some(i + 1)
            })

Copilot

🟡 Not ready to approve

The new signtool password redaction logic can inadvertently redact the final file operand when /p is provided without a value, making failures unnecessarily hard to diagnose.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Comments suppressed due to low confidence (1)

crates/cargo-wdk/src/actions/build/package_task.rs:560

The /p redaction logic can end up redacting the final file operand when the user accidentally supplies /p without a value (because cargo-wdk appends the file path after user args). That makes the resulting error/log output much harder to diagnose (the file being signed becomes <hidden>), even though the file path isn’t secret. Consider skipping redaction when the would-be redacted index is the final file operand.

            .enumerate()
            .filter_map(|(i, arg)| {
                (arg.eq_ignore_ascii_case("/p") && i + 1 < arg_refs.len()).then_some(i + 1)
            })
            .collect();

Files reviewed: 10/10 changed files
Comments generated: 0 new
Review effort level: Low

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot

🟡 Not ready to approve

A new unit-test helper in package_task.rs compares &[&str] directly to Vec<String> (won’t compile), and the README currently doesn’t reflect the implemented “empty/whitespace args => default signing” behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Comments suppressed due to low confidence (1)

crates/cargo-wdk/README.md:126

This section says that whenever --signtool-args is provided, the caller owns the full signtool sign option set, but the CLI parser treats empty/whitespace (and empty quotes) as no args and therefore falls back to the default auto-generated test certificate behavior. Please document this special-case (or alternatively reject empty values) so scripting mistakes don’t silently change signing behavior.

- When `--signtool-args` is **omitted**, cargo-wdk signs with the auto-generated WDR test certificate as described above.
- When `--signtool-args` is **provided**, you own the full `signtool sign` option set (certificate selection, digest algorithm, etc.). `cargo-wdk` will prepend the `sign` verb to your arguments and append the trailing file operand so you should not provide them.

`--signtool-args` applies only when signing is enabled; supplying it with `--sign-mode=off` is an error.

Files reviewed: 10/10 changed files
Comments generated: 1
Review effort level: Low

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

krishnakumar4a4 · 2026-07-30T03:25:29Z

-    /// Signs the specified file using signtool command using certificate from
-    /// certificate store.
+    /// Signs the file with `signtool` by executing the following command:
+    /// `sign <signtool_args...> <file>`


Suggested change

/// `sign <signtool_args...> <file>`

/// `sign <signtool_args...> <file_path>`

krishnakumar4a4 · 2026-07-30T03:47:08Z

+            self.generate_certificate()?;
+            self.copy(&self.src_cert_file_path, &self.dest_cert_file_path)?;
+            // Default WDR test-cert switches.
+            vec![


Instead of calling to_string on each item. We could

["/v", "/s", WDR_TEST_CERT_STORE, "/n", WDR_LOCAL_TEST_CERT, "/t", DEFAULT_TIMESTAMP_URL, "/fd", "SHA256"] .map(ToString::to_string) .to_vec()

krishnakumar4a4 · 2026-07-30T06:38:50Z

+        }
+
+        #[test]
+        fn sign_redacts_password_value() {


Suggested change

fn sign_redacts_password_value() {

fn sign_redacts_password_value_arg_by_redaction_index() {

krishnakumar4a4 · 2026-07-30T10:08:04Z

    ) -> Self {
        let cwd = self.cwd.clone();
-        self.expect_final_package_dir_exists(driver_name, &cwd, true)
+        self.expect_final_package_dir_exists(driver_name, &cwd, false)


The name of the function and its responsibility is confusing now. Earlier expect_final_package_dir_exists with true indicates that the setup sets up only the mock_fs_provider.expect_exists() to return true.

Now with new changes, the function name and boolean value not communicating the intent as it is doing multiple things.
.expect_final_package_dir_exists(...true) -> expects dir, removal and creation
.expect_final_package_dir_exists(...false) -> expects no dir, no removal but there will be creation

Ideally, I would have liked to keep the assertions separate. But if we decide to keep it as single function to reduce verbosity, .expect_final_package_dir_removal(driver_name, &cwd, true) could be a better name which communicates what the function would do differently with the provided boolean value. Assuming the call to exists and create_dir will always be called.

I think expect_final_package_dir_creation is better as:

creation is always done in both cases

really creation is the main thing we want to verify (we care less about deletion etc.)

IMO, Removal is equally important, as it represents the new behaviour we introduced.
If we go with expect_final_package_dir_creation, I would also like to see a separate test that explicitly verifies the deletion behaviour.

I'm actually fine with the deletion check being just a part of the creation test. Deletion is only a secondary detail. The main goal is to get a package created which the user can deploy and use. Deletion is there just to avoid staleness in that process. So yeah, one test is perhaps okay. We can discuss over a call as well if you feel strongly about this.

krishnakumar4a4 · 2026-07-30T10:29:06Z

 /// Signing mode.
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Clone, PartialEq, Eq)]
 pub enum SignMode {


The Profile type is declared in src/actions/mod.rs, but it is only used by the BuildTask module.

In contrast, SignMode and TargetPlatform are declared directly within the PackageTask module, as they are only used there. This feels inconsistent.

krishnakumar4a4 · 2026-07-30T10:41:39Z

+
+            // First build produces a signed driver binary we can reuse as an
+            // independent second file operand.
+            run_build_cmd(&project_path, Some(&["--signtool-args", common_args]), None);


Since the goal was to sign an additional file passed through --signtool-args, we can create a random file ourselves and let the build sign it. There is no need to find a DLL, copy it, strip its signature, and so on.

This is what I felt too. That extra build seems wasteful. But signtool cannot sign arbitrary types of files. It is limited to things like DLLs, EXEs, CABs etc. None of them are easy to create by hand. We could carry one in the codebase but that also seems awkward.

@svasista-ms can you please research and find out which file type amongst those supported by signtool can we easily create on the fly?

Relocate shared types out of `actions/mod.rs` so each lives in the action module that uses it, leaving `actions/mod.rs` as a pure module-tree root: - `Profile`, `to_target_triple` (+ target-triple consts) -> `actions/build` - `DriverType`, `KMDF_STR`/`UMDF_STR`/`WDM_STR` -> `actions/new` Update imports in `cli.rs`, `build/mod.rs`, `build/build_task.rs`, `build/tests.rs`, and `new/mod.rs` accordingly. Matches the existing placement of `SignMode`/`TargetPlatform` in the `build` module.

- build the default signtool switches via `[...].map(ToString::to_string)` instead of per-item `.to_string()` pushes - add a comment explaining the `/p` password redaction index logic - doc: `sign <signtool_args...> <file_path>` - rename test to `sign_redacts_password_value_arg_by_redaction_index`

…equence

Copilot

🟡 Not ready to approve

A newly added unit test helper compares &[&str] to Vec<String> directly in a mock predicate (won’t compile) and needs a small fix before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Suppressed comments (1)

crates/cargo-wdk/src/actions/build/package_task.rs:956

expect_signtool_args compares args (type &[&str] from CommandExec::run_with_redaction) directly to expected (type Vec<String>), which will not compile. Convert the observed args into Vec<String> (or change expected to Vec<&str>) before comparing.

                .withf(move |command, args, redaction_indices, _env, _cwd| {
                    command == "signtool"
                        && args == expected
                        && redaction_indices == expected_redaction_indices.as_slice()
                })

Files reviewed: 13/13 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

svasista-ms added 3 commits July 7, 2026 09:53

feat: test signing customization

bdbbe77

Refactor build signing options to use --signtool-args for certifica…

4d0063f

…te selection

test: move functional tests for --signtool-args passthrough into a …

9753ca4

…separate module

Copilot AI review requested due to automatic review settings July 7, 2026 11:13

Copilot started reviewing on behalf of svasista-ms July 7, 2026 11:14 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/tests/build_command_test.rs

refactor: improve staging and final package directory handling in pac…

6099a73

…kaging process

Copilot AI review requested due to automatic review settings July 8, 2026 10:31

Copilot started reviewing on behalf of svasista-ms July 8, 2026 10:32 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/README.md Outdated

feat: enhance signtool argument handling and improve security warnings

3f7206b

Copilot AI review requested due to automatic review settings July 12, 2026 05:32

Copilot started reviewing on behalf of svasista-ms July 12, 2026 05:32 View session

Copilot AI reviewed Jul 12, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/providers/exec.rs

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

feat: enhance signtool argument handling and improve parsing logic

dcadac9

Copilot AI review requested due to automatic review settings July 12, 2026 12:58

Copilot started reviewing on behalf of svasista-ms July 12, 2026 12:59 View session

Copilot AI reviewed Jul 12, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

svasista-ms marked this pull request as ready for review July 13, 2026 04:27

refactor: remove staging paths in packaging process

b66c678

Copilot AI review requested due to automatic review settings July 14, 2026 17:15

Copilot started reviewing on behalf of svasista-ms July 14, 2026 17:16 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/cargo-wdk/tests/build_command_test.rs Outdated

Comment thread crates/cargo-wdk/src/cli.rs Outdated

krishnakumar4a4 requested changes Jul 15, 2026

View reviewed changes

test: add tests for handling empty signtool args and sign mode valida…

653627a

…tion

Copilot AI review requested due to automatic review settings July 15, 2026 04:48

Copilot started reviewing on behalf of svasista-ms July 15, 2026 04:49 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs

refactor: move build command args tests into a separate module

936780f

svasista-ms added 2 commits July 29, 2026 15:07

refactor(cargo-wdk): move default signtool switches into `sign_and_ve…

fcbc786

…rify`

fix(exec): add comment for lifetime requirement in run_with_redaction

de3cfdf

Copilot AI review requested due to automatic review settings July 29, 2026 09:39

Copilot started reviewing on behalf of svasista-ms July 29, 2026 09:39 View session

Copilot AI reviewed Jul 29, 2026

View reviewed changes

gurry reviewed Jul 29, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/cli.rs Outdated

gurry reviewed Jul 29, 2026

View reviewed changes

Comment thread crates/cargo-wdk/README.md Outdated

Comment thread crates/cargo-wdk/README.md Outdated

svasista-ms added 2 commits July 29, 2026 18:44

refactor(cargo-wdk): replace SignMode TryFrom with `BuildArgs::get_…

77a3e71

…sign_mode` and drop qualified `Result/Ok` paths

docs(cargo-wdk): edit --signtool-args note

2eed294

Copilot AI review requested due to automatic review settings July 29, 2026 13:15

Copilot started reviewing on behalf of svasista-ms July 29, 2026 13:16 View session

Copilot AI reviewed Jul 29, 2026

View reviewed changes

docs(cargo-wdk): remove extra signtool related documentation

f2a8986

Copilot AI review requested due to automatic review settings July 30, 2026 02:32

Copilot started reviewing on behalf of svasista-ms July 30, 2026 02:33 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

svasista-ms added 2 commits July 30, 2026 09:35

fix: ensure file operand is not redacted when password is missing

5a0bb10

refactor: rename get_sign_mode to sign_mode

2fbf359

Copilot AI review requested due to automatic review settings July 30, 2026 04:10

Copilot started reviewing on behalf of svasista-ms July 30, 2026 04:10 View session

Copilot AI reviewed Jul 30, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs

krishnakumar4a4 requested changes Jul 30, 2026

View reviewed changes

svasista-ms added 4 commits July 31, 2026 15:17

test(cargo-wdk): assert package dir recreation ordering via mockall S…

87ef974

…equence

test(cargo-wdk): simplify extra-operand signing test to a single build

8139c0c

Copilot AI review requested due to automatic review settings July 31, 2026 11:46

Copilot started reviewing on behalf of svasista-ms July 31, 2026 11:47 View session

Copilot AI reviewed Jul 31, 2026

View reviewed changes

	fn build_off_mode_maps_to_off() {
	fn build_sign_mode_off_maps_correctly() {

	fn build_signtool_args_with_verify_signature_maps_both() {
	fn build_verify_signature_works_with_signtool_args() {

		@@ -304,25 +402,119 @@ mod tests {

		#[test]
		fn build_rejects_verify_signature_when_sign_mode_is_off() {

	/// `sign <signtool_args...> <file>`
	/// `sign <signtool_args...> <file_path>`

	fn sign_redacts_password_value() {
	fn sign_redacts_password_value_arg_by_redaction_index() {

Uh oh!

Conversation

svasista-ms commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Behavior change

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gurry Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

svasista-ms commented Jul 7, 2026 •

edited

Loading

codecov-commenter commented Jul 7, 2026 •

edited

Loading

gurry Jul 29, 2026 •

edited

Loading

gurry Jul 29, 2026 •

edited

Loading