Update and replace many dependencies - #1305
Open
Jake Bailey (jakebailey) wants to merge 8 commits into
Open
Conversation
| import { getOIDCCredential } from './oidc'; | ||
|
|
||
| const tmpName = promisify(tmp.tmpName); | ||
| async function withTemporaryPackage<T>(fn: (packagePath: string) => Promise<T>): Promise<T> { |
Member
Author
There was a problem hiding this comment.
This would be better as a using disposable, but that requires newer Node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm interested this since vsce is now in the TypeScript dev dep tree, and has significant dep count and audit alerts.
Each commit is its own thing, which I can split into multiple PRs if desired. It's also technically a dupe of #1202, so it's ok if that happens and I rebase.
I'll also note that while I'm raising the minimum node engine to 20.19, the
@azure/identitypackage did a bump to 22+ in a minor version, which means that vsce is technically also 22+ if someone relocks. So, there's a bunch more that could probably get updated.I also have on another branch something that converts the repo to ESM, which is possible thanks to require(ESM). This does simplify some dep integration, but, is probably not worth much.
There are other deps I'd love to be able to replace with something more lightweight, like
glob, but that's likely to cause breaking changes. Happy to discuss that, though.