test: prevent watch mode from retriggering - #1301
Closed
Benjamin Christopher Simmonds (benibenj) wants to merge 1 commit into
Closed
test: prevent watch mode from retriggering#1301Benjamin Christopher Simmonds (benibenj) wants to merge 1 commit into
Benjamin Christopher Simmonds (benibenj) wants to merge 1 commit into
Conversation
Ignore temporary fixture directories generated by the test suite so Mocha watch mode does not rerun indefinitely. Fixes #1215. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/test/fixtures/tmp-*directories in Mocha watch modenpm run watch:testfrom retriggering indefinitely when tests create temporary fixturesFixes #1215.
Validation
npm run compilenpm test(179 passing; two unrelated Windows failures in the existingversiontest: a 5-secondnpm versiontimeout and subsequent EPERM cleanup failure)git diff --checkwatch-ignoreglob