Initial changes: Decoupling data workspace extension from ADS to vscode with working build #20813

ssreerama · 2025-12-16T04:30:39Z

Pull Request Template – vscode-mssql

Description

This PR does the following changes to the repo

Copied extension from azuredatastudio repository to vscode-mssql/extensions/data-workspace/
Updated package.json - Changed name, publisher (ms-mssql), repository URLs, engines, scripts, and devDependencies
Fixed TypeScript config: Changed ES2024→ES2022 target, updated typings paths, fixed main entry point to "./out/src/main.js"
Created .vscodeignore: Properly configured to include compiled output for VSIX packaging
Added Azure DevOps pipeline: Created build template build-data-workspace.yml
Integrated GitHub Actions: Created custom build action and added full workflow coverage (build, lint, test, package, VSIX size tracking)
Configured localization: Added to extraction script, created l10n/ directory, updated LocProject.json
Updated VS Code debugging: Added data-workspace to launch.json "Run All Extensions" configuration
Updated documentation: Added data-workspace to README.md
Temporary ADS dependencies: Commented out ADS git imports with TODO markers for Phase 2 cleanup
Telemetry event package info get method fixed with correct path
ESLint: eslint 9 migration and Auto-fixed 3030 formatting errors - now passing with 0 errors, 80 warnings
DevDependencies: Added all required packages and matched versions with mssql extension

Test fixes:

Package.json updated with test path to discover the tests
Test framework conversion, replaced ADS specific @microsoft/azdata-test with VsCode's @vscode/test-electron
Added vscode.workspace.findFiles stubs to allow extension activation in tests Mock improvements: Changed activation stubs to return Promises for few tests
Dialog tests: Commented out entire test bodies with TODO explaining they need VS Code UI migration

Code Changes Checklist

New or updated unit tests added
All existing tests pass (npm run test)
Code follows contributing guidelines
Telemetry/logging updated if relevant
No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

github-actions · 2025-12-16T04:38:49Z

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	5285 KB	5284 KB	⚪ -1 KB ( 0% )
sql-database-projects VSIX	5668 KB	5668 KB	⚪ 0 KB ( 0% )
data-workspace VSIX	null KB	532 KB	⚪ 532 KB ( 0% )

codecov-commenter · 2025-12-16T04:39:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.90%. Comparing base (6ebbedc) to head (a17ad30).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #20813   +/-   ##
=======================================
  Coverage   65.90%   65.90%           
=======================================
  Files         210      210           
  Lines       19991    19991           
  Branches     2596     2596           
=======================================
  Hits        13175    13175           
  Misses       6718     6718           
  Partials       98       98

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

….yml - Updated build-and-test.yml workflow to include data-workspace:

- Added data-workspace to localization extraction config (scripts/localization-extract.js) - Updated VS Code launch configuration to include data-workspace for debugging (.vscode/launch.json) - Added data-workspace documentation to main README.md (repository layout and development sections) - Updated GitHub workflows README to reflect all three extensions

Benjin · 2025-12-16T21:45:18Z

Looks like neither the linter nor tests are running correctly in the pipelines. Linter should run and pass, and the tests should run successfully (but okay if they're not all passing because that'll be a follow-up).

…metry package info method

…d lint issues

… UI tests and todo comment to revist with ADS code removal

ssreerama · 2025-12-17T17:01:48Z

Done. The linter is now working, and the test suites are being discovered and running successfully. There are a few test failures remaining, which I will address in my next PR

Benjin · 2025-12-17T17:56:12Z

extensions/data-workspace/package.json

+	"license": "SEE LICENSE IN LICENSE.txt",
+  "icon": "images/extension.png",
+  "aiKey": "29a207bb14f84905966a8f22524cb730-25407f35-11b6-4d4e-8114-ab9e843cb52f-7380",
+  "homepage": "https://github.com/Microsoft/vscode-mssql/blob/main/extensions/data-workspace/README.md",


"Microsoft" should be lower-cased in this URL

Benjin · 2025-12-17T17:56:31Z

extensions/data-workspace/package.json

+    "url": "https://github.com/Microsoft/vscode-mssql.git"
+  },
+  "bugs": {
+    "url": "https://github.com/Microsoft/vscode-mssql/issues"


same with these two

Benjin · 2025-12-17T17:59:06Z

extensions/data-workspace/.vscode/launch.json

+        // Note for debugging the VS Code version of the extension, currently you will need to modify
+        // the package.json and manually copy over the values from package.vscode.json into package.json
+        // (otherwise you'll get errors since other extensions depend on an extension with the name
+        //  data-workspace-vscode, not data-workspace)


Are these comments still true?

Maybe the need reversing: do we now build data-workspace-vscode by default, and need to swap things around when building for ADS?

Is there any scope to build the data-workspace from VS Code for ADS before it’s retired? My understanding is that with Phase 2 (removing ADS dependency completely), we won’t need to link ADS at all. Please correct me if I’m wrong.

Benjin · 2025-12-17T18:00:49Z

Commented out ADS git imports with TODO markers for Phase 2 cleanup

Can you add a comment in the code where this is happening for what "phase 2 cleanup" entails and add a link to a github issue for tracking that?

Initial changes: moving data workspace to vscode with working build

c35557b

ssreerama added 4 commits December 16, 2025 10:38

updating the homepage path

6a661d1

updating the entry point to correct path

b3697b5

- Created build action at .github/actions/build-data-workspace/action…

7767fc3

….yml - Updated build-and-test.yml workflow to include data-workspace:

ssreerama self-assigned this Dec 16, 2025

ssreerama added this to the January 2026 Release milestone Dec 16, 2025

ssreerama marked this pull request as ready for review December 16, 2025 18:54

ssreerama requested review from Benjin, aasimkhan30, allancascante, caohai, kburtram, laurenastrid1, lewis-sanchez and manujoseph85 as code owners December 16, 2025 18:54

updating the telemetry packageJson path

6ebb1aa

ssreerama changed the title ~~Initial changes: moving data workspace to vscode with working build~~ Initial changes: Decoupling data workspace extension from ADS to vscode with working build Dec 16, 2025

ssreerama added 3 commits December 16, 2025 21:15

Add ESLint 9 flat config for data-workspace extension and fixing tele…

4054809

…metry package info method

fixing the test path and verifying test discovery and execution, fixe…

9ec0fb4

…d lint issues

fixing few tests by mocking workspace findfiles, comented 7ADS dialog…

a17ad30

… UI tests and todo comment to revist with ADS code removal

Benjin reviewed Dec 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initial changes: Decoupling data workspace extension from ADS to vscode with working build #20813

Initial changes: Decoupling data workspace extension from ADS to vscode with working build #20813

ssreerama commented Dec 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 16, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Dec 16, 2025 •

edited

Loading

Uh oh!

Benjin commented Dec 16, 2025

Uh oh!

ssreerama commented Dec 17, 2025

Uh oh!

Benjin Dec 17, 2025

Uh oh!

Benjin Dec 17, 2025

Uh oh!

Benjin Dec 17, 2025

Uh oh!

ssreerama Dec 17, 2025

Uh oh!

Benjin commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Initial changes: Decoupling data workspace extension from ADS to vscode with working build #20813

Are you sure you want to change the base?

Initial changes: Decoupling data workspace extension from ADS to vscode with working build #20813

Conversation

ssreerama commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template – vscode-mssql

Description

Code Changes Checklist

Reviewers: Please read our reviewer guidelines

Uh oh!

github-actions bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Changes

Uh oh!

codecov-commenter commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Benjin commented Dec 16, 2025

Uh oh!

ssreerama commented Dec 17, 2025

Uh oh!

Benjin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

ssreerama Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Benjin commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ssreerama commented Dec 16, 2025 •

edited

Loading

github-actions bot commented Dec 16, 2025 •

edited

Loading

codecov-commenter commented Dec 16, 2025 •

edited

Loading