Fix for #513 - _ParseBinaryExpr builds a node whose range excludes it's children - #514
Open
Mark Beznos (vibbix) wants to merge 2 commits into
Open
Fix for #513 - _ParseBinaryExpr builds a node whose range excludes it's children#514Mark Beznos (vibbix) wants to merge 2 commits into
_ParseBinaryExpr builds a node whose range excludes it's children#514Mark Beznos (vibbix) wants to merge 2 commits into
Conversation
…tion, instead of the preparsed one
Mark Beznos (vibbix)
changed the title
_ParseBinaryExpr builds a node whose range excludes it's children
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the fix for #513 - "
_ParseBinaryExprbuilds a node whose range excludes it's children"All that was needed was setting the
node.offsetback a bit. Added the test-suite from earlier, so it points correctly now.