auth: allowing custom clouds to opt in/out of the SDK Profiles - #2393
Merged
Brandon Waterloo [MSFT] (bwateratmsft) merged 3 commits intoSep 2, 2026
Conversation
This commit exposes a new feature flag for `isCustomCloud`, the intention being here to differentiate between custom clouds which only support the Profiles (and thus aren't really usable today) and those which support the full API surface. I've intentionally opted to call this `isCustomCloud` rather than `useProfiles` or something to try and differentiate Azure Stack Hub and other custom clouds, since right now multiple components (e.g. storage hang off of the SDK clients, which do [regular/custom clouds] and do not [Azure Stack Hub] expose the SDK clients in question).
Copilot started reviewing on behalf of
Tom Harvey (tombuildsstuff)
August 31, 2026 12:33
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how custom Azure cloud environments are interpreted so that custom clouds can opt out of being treated as “Azure Stack Hub” (hybrid/profile-only) and instead use the full modern SDK clients when appropriate.
Changes:
- Adds a
CustomCloudEnvironmentParameterstype that extends Azure SDK environment parameters with an optionalisAzureStackflag. - Updates
getConfiguredAzureEnvso custom environments default toisCustomCloud: true(hybrid/profile behavior) unless explicitly configured withisAzureStack: false. - Improves in-file documentation describing the new configuration shape and intent.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Brandon Waterloo [MSFT] (bwateratmsft)
changed the title
…rameters` to allow setting `isAzureStack`
Brandon Waterloo [MSFT] (bwateratmsft)
approved these changes
Sep 1, 2026
Contributor
|
Looks good, ready for me to merge? |
Contributor
Author
|
Brandon Waterloo [MSFT] (@bwateratmsft) that'd be great, thanks :) |
Brandon Waterloo [MSFT] (bwateratmsft)
merged commit Sep 2, 2026
6618b45
into
microsoft:main
4 checks passed
Tom Harvey (tombuildsstuff)
deleted the
f/explicitly-specifying-custom-cloud
branch
September 2, 2026 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes a new feature flag for
isCustomCloud, the intention being here to differentiate between custom clouds which only support the Profiles (and thus aren’t really usable today) and those which support the full API surface.I’ve intentionally opted to call this
isCustomCloudrather thanuseProfilesor something to try and differentiate clouds which use the SDK Profiles (which don’t contain the SDK clients by all components, so Azure Stack Hub will currently fail) from those which don’t (e.g. a custom defined cloud, which can use the regular API)