CoR: Harden requirements parsing - #1836
Merged
Matthew Fisher (MicroFish91) merged 1 commit intoSep 14, 2026
Merged
Matthew Fisher (MicroFish91) merged 1 commit into
Matthew Fisher (MicroFish91) merged 1 commit into
Conversation
Matthew Fisher (MicroFish91)
requested a review
from a team
as a code owner
September 12, 2026 16:21
Matthew Fisher (MicroFish91)
changed the title
Matthew Fisher (MicroFish91)
force-pushed
the
microfish91-cor-requirements-json-validation
branch
from
September 12, 2026 16:32
7542310 to
7dfd153
Compare
Matthew Fisher (MicroFish91)
changed the base branch from
microfish91-harden-cor-parsing
to
feat/CoR
September 12, 2026 16:33
Matthew Fisher (MicroFish91)
changed the title
Matthew Fisher (MicroFish91)
added this pull request to stack #1838
September 12, 2026 16:39
Matthew Fisher (MicroFish91)
deleted the
microfish91-cor-requirements-json-validation
branch
September 14, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed requirements artifacts can currently leak unchecked values into the webview, including non-object roots, invalid workspace signals, and object answers coerced to strings.
This change adds shared runtime JSON guards and applies them to requirements parsing and pending-create marker parsing. It preserves valid siblings in partially malformed requirements while rejecting unsupported nested shapes, maps object answers to
null, and accepts pending-create timestamps only when they are finite numbers.Tests cover the shared guards, non-object roots, malformed nested fields, partial valid data, unsupported answer objects, and existing requirements telemetry behavior.