CoR: Improve package metadata validation - #1835
Merged
Matthew Fisher (MicroFish91) merged 1 commit intoSep 14, 2026
Conversation
Matthew Fisher (MicroFish91)
requested a review
from a team
as a code owner
September 12, 2026 15:54
Matthew Fisher (MicroFish91)
changed the title
Matthew Fisher (MicroFish91)
force-pushed
the
microfish91-cor-package-metadata-validation
branch
from
September 12, 2026 16:35
4d86cf8 to
26914d6
Compare
Matthew Fisher (MicroFish91)
added this pull request to stack #1838
September 12, 2026 16:39
Matthew Fisher (MicroFish91)
deleted the
microfish91-cor-package-metadata-validation
branch
September 14, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace-owned package.json files can contain valid JSON with unexpected runtime types, so TypeScript casts alone could classify invalid frontend dependencies or select non-string dev scripts.
This change validates parsed package metadata as a JSON object, accepts only string-valued dependency and script records, and uses own-property checks for frontend framework keys. Missing and malformed files retain the existing fallback behavior.