Use symbol comparison instead of type string comparison #7257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the UseProperAssertMethodsAnalyzer by replacing string-based type comparison (ToDisplayString()) with proper symbol-based comparison using SymbolEqualityComparer.Default.Equals(). This is a best practice in Roslyn analyzers that prevents potential issues with type name resolution.
Changes:
- Added
SystemLinqEnumerableconstant toWellKnownTypeNameshelper class - Modified analyzer to retrieve and pass
System.Linq.Enumerabletype symbol through analysis methods - Replaced all string comparisons against
"System.Linq.Enumerable"with symbol equality comparisons - Added proper null handling for the optional
enumerableTypeSymbolparameter
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Analyzers/MSTest.Analyzers/Helpers/WellKnownTypeNames.cs | Added constant for System.Linq.Enumerable type name |
| src/Analyzers/MSTest.Analyzers/UseProperAssertMethodsAnalyzer.cs | Replaced string-based type comparison with symbol comparison for LINQ type checks; added proper null handling for optional symbol |
Youssef1313
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7174