Remove internal naming from comments and docs - #658
Merged
Corina (corinagum) merged 3 commits intoAug 25, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes internal service naming (e.g., SMBA/APX) from comments and documentation across tests, samples, and core XML docs to make the repo’s guidance more externally consumable.
Changes:
- Updated various test/sample comments to replace internal acronyms with generic “service” wording.
- Updated integration test README wording to remove internal naming references.
- Renamed a demo variable from
smbatoserviceUrlfor clearer intent.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/TeamsApisDemo/Program.cs | Renames a local variable from smba to serviceUrl. |
| test/Microsoft.Teams.Core.UnitTests/Http/BotRequestContextTests.cs | Updates a test comment to remove “SMBA” naming. |
| test/Microsoft.Teams.Apps.BotBuilder.UnitTests/CompatConversationsTests.cs | Updates test comments to remove “APX” naming. |
| test/IntegrationTests/README.md | Removes “(SMBA/APX)” from README description. |
| src/Microsoft.Teams.Core/Schema/ConversationExtensions.cs | Updates XML docs to remove “APX” naming. |
| samples/PABot/Bots/SsoBot.cs | Updates a sample comment to remove “APX” naming. |
Suppressed comments (1)
test/Microsoft.Teams.Apps.BotBuilder.UnitTests/CompatConversationsTests.cs:436
- Same as above: “the service” is ambiguous; prefer explicitly calling out the Bot Framework service to keep the comment actionable without using internal acronyms.
// When the service returns 202 Accepted with no body, SendActivityAsync returns null
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Review feedback: "the service" is ambiguous because the code itself runs in a service. Comments only, no behavior change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mehak Bindra (MehakBindra)
approved these changes
Aug 25, 2026
Corina (corinagum)
deleted the
corinagum-remove-internal-name-from-public-docs
branch
August 25, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up comments and docs