Skip to content

Lower .NET Framework floor to net462; retarget release as v5.4.4 #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelcfanning wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Lower .NET Framework floor to net462; retarget release as v5.4.4 #3123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ReleaseHistory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ Each release entry below is prefixed with one of:

Entries are terse by design: one line per change, present-tense behavior, complete but only essential data. No issue/PR archaeology or narrative — that history lives in the engineering system.

## **v5.5.0** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/v5.5.0) | [Driver](https://www.nuget.org/packages/Sarif.Driver/v5.5.0) | [Converters](https://www.nuget.org/packages/Sarif.Converters/v5.5.0) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/v5.5.0) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/v5.5.0)
* BRK: Raise the .NET Framework floor to `net481` for all packages, dropping the `net461` and `net462` targets.
* DEP: Update the minor-and-patch dependency group, notably `Microsoft.Diagnostics.Tracing.TraceEvent` 3.2.4, `System.Collections.Immutable` and `System.Reflection.Metadata` 9.0.8, and `System.Data.SqlClient` 4.9.1.
## **v5.4.4** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/v5.4.4) | [Driver](https://www.nuget.org/packages/Sarif.Driver/v5.4.4) | [Converters](https://www.nuget.org/packages/Sarif.Converters/v5.4.4) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/v5.4.4) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/v5.4.4)
* DEP: Update the minor-and-patch dependency group, notably `Microsoft.Diagnostics.Tracing.TraceEvent` 3.2.4, `System.Collections.Immutable` and `System.Reflection.Metadata` 9.0.8, and `System.Data.SqlClient` 4.9.1; these drop `net461`, raising the `net461` packages to a `net462` floor.
* DEP: `Microsoft.Extensions.Logging.ApplicationInsights` 2.23.0; `ServiceProviderFactory` configures Application Insights via connection string instead of the obsolete instrumentation-key API.

## **v5.4.3** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/v5.4.3) | [Driver](https://www.nuget.org/packages/Sarif.Driver/v5.4.3) | [Converters](https://www.nuget.org/packages/Sarif.Converters/v5.4.3) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/v5.4.3) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/v5.4.3)
Expand Down
8 changes: 4 additions & 4 deletions scripts/Projects.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@
$Frameworks = @{}

# .NET Framework versions for which we build.
# net481 is our minimal supported .NET Framework, and the floor
# net462 is our minimal supported .NET Framework, and the floor
# required for internal Microsoft consumption.
$Frameworks.NetFx = @("net481")
$Frameworks.NetFx = @("net462")

# Frameworks for which we build libraries.
$Frameworks.Library = @("netstandard2.0") + $Frameworks.NetFx

# net481 is the current minimum supported .NET
# net462 is the current minimum supported .NET
# framework, so we use it for all client tools.
# it is fine to support a down-level, unsupported
# .NET framework for a library, because the client
# app can then control timing for updating to a more
# current .NET framework. When we control the app
# we will require the minimal supported version to
# ensure that the runtime we are executing on is secure.
$Frameworks.ApplicationNetFx = @("net481")
$Frameworks.ApplicationNetFx = @("net462")

# Frameworks for which we build applications.
$Frameworks.Application = @("net8.0") + $Frameworks.ApplicationNetFx
Expand Down
16 changes: 8 additions & 8 deletions src/Nuget/Sarif.Multitool.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@
</metadata>
<files>
<!-- The subfolder layout for the different TargetFrameworks is intentionally inconsistent -->
<!-- net481 and net8.0 pack to tools\TargetFramework\* for backcompat -->
<file src="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net481\Sarif.Multitool.exe.config"
target="tools\net481" />
<file src="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net481\**"
target="tools\net481"
exclude="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net481\Sarif*;bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net481\WorkItems.dll;" />
<file src="bld\bin\Signing\net481\**"
target="tools\net481" />
<!-- net462 and net8.0 pack to tools\TargetFramework\* for backcompat -->
<file src="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net462\Sarif.Multitool.exe.config"
target="tools\net462" />
<file src="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net462\**"
target="tools\net462"
exclude="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net462\Sarif*;bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net462\WorkItems.dll;" />
<file src="bld\bin\Signing\net462\**"
target="tools\net462" />

<!-- net8.0 packs to tools\TargetFramework\any\* for compatibility with dotnet tool install -->
<file src="bld\bin\$platform$_$configuration$\Sarif.Multitool\Publish\net8.0\**"
Expand Down
2 changes: 1 addition & 1 deletion src/Sarif.Converters/Sarif.Converters.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Sarif.Driver/Sarif.Driver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
</PropertyGroup>

Expand Down
4 changes: 2 additions & 2 deletions src/Sarif.Multitool.Library/Sarif.Multitool.Library.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0;</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<RootNamespace>Microsoft.CodeAnalysis.Sarif.Multitool</RootNamespace>
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
</PropertyGroup>
Expand Down Expand Up @@ -69,7 +69,7 @@
</ItemGroup>

<ItemGroup>
<None Include="default.configuration.xml" Pack="true" PackagePath="lib/netstandard2.0;lib/net481" CopyToOutputDirectory="PreserveNewest" />
<None Include="default.configuration.xml" Pack="true" PackagePath="lib/netstandard2.0;lib/net462" CopyToOutputDirectory="PreserveNewest" />
<None Include="..\..\policies\*" Pack="true" PackagePath="policies" />
<None Include="**\*.cs" Pack="true" PackagePath="src" />
<None Include="..\..\ReleaseHistory.md" Pack="true" PackagePath="/" />
Expand Down
4 changes: 2 additions & 2 deletions src/Sarif.Multitool/Sarif.Multitool.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<!-- net481 is the current minimal supported .NET framework. -->
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<!-- net462 is the current minimal supported .NET framework. -->
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Sarif.WorkItems/Sarif.WorkItems.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Sarif/Sarif.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Test.Plugins/Test.Plugins.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<IsPackable>false</IsPackable>
<IsTestProject>false</IsTestProject>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/Test.UnitTests.Sarif.WorkItems/Test.UnitTests.Sarif.WorkItems.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
<RootNamespace>Test.UnitTests.Sarif.WorkItems</RootNamespace>
Expand All @@ -34,7 +34,7 @@
<PackageReference Include="xunit.runner.visualstudio" PrivateAssets="All" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net481'">
<ItemGroup Condition="'$(TargetFramework)' == 'net462'">
<PackageReference Include="System.Reflection.Metadata" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/Test.UnitTests.WorkItems/Test.UnitTests.WorkItems.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions src/WorkItems/WorkItems.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<!-- We require net481 as a minimal framework due to dependency such as Microsoft.Extensions.Logging.Console -->
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net481</TargetFrameworks>
<!-- net462 is the floor: System.Collections.Immutable / System.Reflection.Metadata 9.x drop net461. -->
<TargetFrameworks Condition="$(OS) == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<Company Condition=" '$(Company)' == '' ">Microsoft</Company>
<Product Condition=" '$(Product)' == '' ">Microsoft SARIF SDK</Product>
<Copyright Condition=" '$(Copyright)' == '' ">© Microsoft Corporation. All rights reserved.</Copyright>
<VersionPrefix>5.5.0</VersionPrefix>
<VersionPrefix>5.4.4</VersionPrefix>

<!-- SchemaVersionAsPublishedToSchemaStoreOrg identifies the current published version on json schema store at https://schemastore.azurewebsites.net/schemas/json/ -->
<SchemaVersionAsPublishedToSchemaStoreOrg>2.1.0</SchemaVersionAsPublishedToSchemaStoreOrg>
Expand Down
Loading