Fix Python multi-line f-strings. - #5272
Open
Yilei (yilei) wants to merge 1 commit into
Open
Conversation
|
Hi can we please merge this PR. I patched it locally and it solved the problem for me. |
|
Any updates on this? |
|
I also hit this and independently reached the same fix as — routing f'''/f""" into dedicated multi-line states — which I now ship as a local grammar override, verified against real tokenization output. One gap worth fixing while you're in there: {{/}} literal braces match the interpolation rule and, in a multi-line state, swallow every following line until a }. Adding [/{{|}}/, 'string'] before the interpolation rule fixes it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This routes
f'''andf"""to dedicates states, which will be closed on matching'''and"""quotes. It also adds the supported raw-string variant prefixes likerf/rF/ ...This should fix #4601.