You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sam Dietrich (Sam Dietrich (@xmaams)) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I'm not the Haskel expert. Did you write this code yourself? One additional test you could add is as script that compares the --list-deps output against the --file-list output.
LGTM, although I'm not the Haskel expert. Did you write this code yourself? One additional test you could add is as script that compares the --list-deps output against the --file-list output.
Added a test to compare vs compile --file-list.
Copilot helped with the Haskell, which is probably for the best... But I did read it closely and it looks fine to me with my limited knowledge. I checked that dependency lists did not change between this build and main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
list-depssubcommand for dependency resolution (such as in cmake) without rebuild.Also add a small test case vs a golden file