Repository navigation
replace Floating UI with a CSS-anchor-positioning-style engine - #36870
Draft
Dmytro Kirpa (dmytrokirpa) wants to merge 9 commits into
Draft
Dmytro Kirpa (dmytrokirpa) wants to merge 9 commits into
Dmytro Kirpa (dmytrokirpa) wants to merge 9 commits into
Conversation
…oning-style engine Port the JavaScript positioning engine into react-positioning and use it in place of @floating-ui/dom: position-area style placements, first-fit fallbacks, margin offsets, containing block detection, boundaries, autoSize, arrow and visibility attributes. Floating UI dependencies are removed. The headless usePositioning is unchanged and keeps its CSS anchor positioning. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YQM28hNQxTep97H3Ur6xDm
Dmytro Kirpa (dmytrokirpa)
force-pushed
the
claude/exciting-fermi-h0j6uv
branch
from
October 12, 2026 17:57
a8dce8a to
69a727b
Compare
📊 Bundle size reportUnchanged fixtures
|
|
Pull request demo site: URL |
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 5 | Changed |
vr-tests-react-components/Charts-HorizontalBarChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-HorizontalBarChart.Basic - Dark Mode.hover.chromium.png | 2213 | Changed |
| vr-tests-react-components/Charts-HorizontalBarChart.Basic.hover.chromium.png | 2934 | Changed |
vr-tests-react-components/Charts-LineChart 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Charts-LineChart.Basic.hover.chromium.png | 2389 | Changed |
| vr-tests-react-components/Charts-LineChart.Basic - Dark Mode.hover.chromium.png | 1615 | Changed |
vr-tests-react-components/Dialog 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Dialog.Integration Combobox Inline.chromium.png | 3929 | Changed |
vr-tests-react-components/InfoLabel 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/InfoLabel.sizes -- open.rest.chromium.png | 2067 | Changed |
vr-tests-react-components/Menu 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu.Scrollable Menu Small Viewport.default.chromium.png | 600 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 599 | Changed |
vr-tests-react-components/Menu Multiline items 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Multiline items.default - RTL.chromium.png | 9577 | Changed |
| vr-tests-react-components/Menu Multiline items.default.chromium.png | 9505 | Changed |
vr-tests-react-components/Popover Converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Popover Converged.positioning - High Contrast.positioned popovers.chromium.png | 277 | Changed |
| vr-tests-react-components/Popover Converged.positioning - RTL.positioned popovers.chromium.png | 19 | Changed |
vr-tests-react-components/Positioning 17 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 956 | Changed |
| vr-tests-react-components/Positioning.arrow - RTL.chromium.png | 1169 | Changed |
| vr-tests-react-components/Positioning.Target display none.chromium.png | 958 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 628 | Changed |
| vr-tests-react-components/Positioning.disable tether.chromium.png | 434 | Changed |
| vr-tests-react-components/Positioning.configuration provider.chromium.png | 748 | Changed |
| vr-tests-react-components/Positioning.explicit overflow padding.chromium.png | 1044 | Changed |
| vr-tests-react-components/Positioning.horizontal overflow - RTL.chromium.png | 1998 | Changed |
| vr-tests-react-components/Positioning.horizontal overflow padding - RTL.chromium.png | 1959 | Changed |
| vr-tests-react-components/Positioning.horizontal overflow padding.chromium.png | 1976 | Changed |
| vr-tests-react-components/Positioning.horizontal overflow.chromium.png | 2006 | Changed |
| vr-tests-react-components/Positioning.offset.chromium.png | 5822 | Changed |
| vr-tests-react-components/Positioning.shiftToCoverTarget with autoSize and async content - horizontal.floating element is within the boundary.chromium.png | 8714 | Changed |
| vr-tests-react-components/Positioning.shiftToCoverTarget with autoSize and async content.floating element is within the boundary.chromium.png | 5167 | Changed |
| vr-tests-react-components/Positioning.vertical overflow padding.chromium.png | 1648 | Changed |
| vr-tests-react-components/Positioning.vertical overflow.chromium.png | 1690 | Changed |
| vr-tests-react-components/Positioning.using boundary rect.chromium.png | 4019 | Changed |
vr-tests-react-components/ProgressBar converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 27 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.disabled input hover.chromium.png | 1319 | Changed |
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
vr-tests-react-components/Tooltip Converged 8 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Tooltip Converged.inverted withArrow - Dark Mode.default.chromium.png | 2 | Changed |
| vr-tests-react-components/Tooltip Converged.inverted withArrow.default.chromium.png | 14 | Changed |
| vr-tests-react-components/Tooltip Converged.positioning - High Contrast.positioned tooltips.chromium.png | 4157 | Changed |
| vr-tests-react-components/Tooltip Converged.positioning - RTL.positioned tooltips.chromium.png | 1068 | Changed |
| vr-tests-react-components/Tooltip Converged.positioning with fallbacks.positioning fallbacks.chromium.png | 632 | Changed |
| vr-tests-react-components/Tooltip Converged.withArrow - High Contrast.default.chromium.png | 15 | Changed |
| vr-tests-react-components/Tooltip Converged.withArrow.default.chromium.png | 1 | Changed |
| vr-tests-react-components/Tooltip Converged.positioning.positioned tooltips.chromium.png | 1067 | Changed |
vr-tests-web-components/MenuList 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/MenuList. - RTL.2nd selected.chromium.png | 17 | Changed |
vr-tests/Callout 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Callout.Top center.default.chromium.png | 2127 | Changed |
vr-tests/Coachmark 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Coachmark.Collapsed.default.chromium.png | 159 | Changed |
vr-tests/Keytip 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/Keytip.Offset.default.chromium.png | 86 | Changed |
| vr-tests/Keytip.Root.default.chromium.png | 55 | Changed |
| vr-tests/Keytip.Disabled.default.chromium.png | 24 | Changed |
vr-tests/react-charting-AreaChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-AreaChart.Custom Accessibility.default.chromium.png | 11 | Changed |
vr-tests/react-charting-VerticalBarChart 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests/react-charting-VerticalBarChart.Basic - Secondary Y Axis.default.chromium.png | 3 | Changed |
There were 13 duplicate changes discarded. Check the build logs for more information.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
New Behavior
Related Issue(s)