Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds hard-delete support to the rm command by introducing a new --purge flag that triggers permanent deletion (via hardDelete=true) and updates docs + VCR recordings accordingly.
Changes:
- Added
--purgeflag tofab rmand documented the new behavior. - Wired
--purgethrough item/workspace deletion flows by setting request query params (hardDelete=true) and adding stronger confirmation messaging. - Added/updated VCR recordings covering purge-delete success across multiple item types.
Reviewed changes
Copilot reviewed 39 out of 57 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[SparkJobDefinition].yaml | Adds purge-delete success recording for SparkJobDefinition. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Reflex].yaml | Adds purge-delete success recording for Reflex. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[MirroredDatabase].yaml | Adds purge-delete success recording for MirroredDatabase. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[MLModel].yaml | Adds purge-delete success recording for MLModel (async create flow included). |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Lakehouse].yaml | Adds purge-delete success recording for Lakehouse. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[KQLQueryset].yaml | Adds purge-delete success recording for KQLQueryset. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[KQLDashboard].yaml | Adds purge-delete success recording for KQLDashboard. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[GraphQLApi].yaml | Adds purge-delete success recording for GraphQLApi. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Eventstream].yaml | Adds purge-delete success recording for Eventstream (async create flow included). |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Eventhouse].yaml | Adds purge-delete success recording for Eventhouse. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Environment].yaml | Adds purge-delete success recording for Environment. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[Dataflow].yaml | Adds purge-delete success recording for Dataflow. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[DataPipeline].yaml | Adds purge-delete success recording for DataPipeline. |
| tests/test_commands/recordings/test_commands/test_rm/test_rm_item_with_purge_delete_success[CopyJob].yaml | Adds purge-delete success recording for CopyJob. |
| tests/test_commands/recordings/test_commands/test_rm/class_setup.yaml | Updates test setup recording (User-Agent/version + workspace ids/contents). |
| src/fabric_cli/parsers/fab_fs_parser.py | Adds --purge flag to rm parser and updates examples/help. |
| src/fabric_cli/commands/fs/rm/fab_fs_rm_workspace.py | Propagates purge deletion to item deletes when deleting items within a workspace flow. |
| src/fabric_cli/commands/fs/rm/fab_fs_rm_item.py | Sets request params for purge deletion when removing a single item. |
| src/fabric_cli/client/fab_api_utils.py | Adds stronger confirmation/warnings for purge deletion, plus minor formatting changes. |
| docs/commands/fs/rm.md | Documents --purge flag and adds examples for soft/force/purge deletion. |
ayeshurun
reviewed
Apr 9, 2026
ayeshurun
reviewed
Apr 9, 2026
ayeshurun
reviewed
Apr 9, 2026
ayeshurun
reviewed
Apr 9, 2026
Co-authored-by: Copilot <[email protected]>
ayeshurun
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--hardflag tormcommand, which permanently deletes the item.