Make LLVM install optional in setup-buildtools#1433
Open
bmehta001 wants to merge 2 commits intomicrosoft:mainfrom
Open
Make LLVM install optional in setup-buildtools#1433bmehta001 wants to merge 2 commits intomicrosoft:mainfrom
bmehta001 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Stop the bootstrap script from pulling LLVM through Chocolatey on every run so existing LLVM installations and non-clang setups are not modified unexpectedly. Files changed: - tools/setup-buildtools.cmd Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows build tools bootstrap script to avoid installing LLVM via Chocolatey unless explicitly requested, aligning setup-buildtools.cmd behavior with the existing INSTALL_LLVM opt-in flow.
Changes:
- Removes
llvmfrom the unconditional Chocolatey install list. - Keeps LLVM installation behind the existing
if DEFINED INSTALL_LLVMgate (install-llvm.cmd). - Clarifies comments in
setup-buildtools.cmdto document LLVM’s optional behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1014
Make
tools/setup-buildtools.cmdstop installing LLVM unlessINSTALL_LLVMis set. This matches the behavior described in the docs.Changes
llvmfrom the unconditional Chocolatey bootstrap package listINSTALL_LLVMgateinstall-llvm.cmdwhen requested