Fix screen reader announcing only button name, not associated description in WPF Gallery#783
Open
mmanolova-msft wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
…tion in WPF Gallery Fold the card Description into AutomationProperties.Name for HeaderTile (5 home tiles) and NavigationCardTemplate (overview/category cards) so Narrator announces both the title and its associated descriptive text. Addresses AzDO 3019241. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mmanolova-msft
force-pushed
the
user/mmanolova/navcard-a11y-description
branch
from
ab744b3 to
c0ffa1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes AzDO 3019241 (MAS 1.3.1 accessibility). In the WPF Gallery app, Narrator announced only a navigation button's title and skipped the associated descriptive text.
Root cause
The buttons had an explicit
AutomationProperties.Namebound only toTitle, which suppresses WPF's default fall-back to the child descriptionTextBlock, so the description was never announced.Fix
Fold the
DescriptionintoAutomationProperties.Namevia aMultiBindingso Narrator announces both the title and the description:Controls/HeaderTile.xaml- the 5 featured tiles on Home (Getting started, Windows design, WPF GitHub, Code samples, Partner Center).Resources/Templates.xaml(NavigationCardTemplate) - the Overview/category cards reused across 13 pages.Consistent with the previously-fixed AzDO 2064065, which also resolved announcement gaps by setting explicit
AutomationProperties.Namevalues.Testing
dotnet buildsucceeds (0 errors).Microsoft Reviewers: Open in CodeFlow