Skip to content

Fix null Name on empty page header description (MAS 4.1.2) #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amarinov-msft wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix null Name on empty page header description (MAS 4.1.2) #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sample Applications/WPFGallery/Controls/PageHeader.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
xmlns:controls="clr-namespace:WPFGallery.Controls"
xmlns:helpers="clr-namespace:WPFGallery.Helpers">

<helpers:NullToVisibilityConverter x:Key="NullToVisibilityConverter"/>
<helpers:EmptyToVisibilityConverter x:Key="EmptyToVisibilityConverter"/>

<Style TargetType="{x:Type controls:PageHeader}">
<Setter Property="Focusable" Value="False"/>
Expand All @@ -25,10 +25,11 @@
</Label>

<Label
AutomationProperties.Name="{Binding Description, RelativeSource={RelativeSource Mode=TemplatedParent}}"
AutomationProperties.HeadingLevel="Level2"
KeyboardNavigation.IsTabStop="True"
KeyboardNavigation.TabIndex="1"
Visibility="{TemplateBinding Description, Converter={StaticResource NullToVisibilityConverter}}"
Visibility="{TemplateBinding Description, Converter={StaticResource EmptyToVisibilityConverter}}"
Focusable="True">
<TextBlock
x:Name="DescriptionTextBlock"
Expand Down
Loading