ci: add release branch compatibility check to PR validation by smamindl · Pull Request #2548 · microsoft/SynapseML

smamindl · 2026-04-14T21:04:41Z

Add a ReleaseBranchCompat job that runs on every PR to master. It rebases each release branch (starting with spark4.0) onto the PR HEAD and runs sbt compile test:compile to catch breakage before it lands in master.

Non-blocking (continueOnError: true)
Matrix-based for easy expansion to more release branches
Reports merge conflicts and compile failures as warnings

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

No. You can skip this section.
Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

No. You can skip this section.
Yes. Make sure you have added samples following below steps.

Find the corresponding markdown file for your new feature in website/docs/documentation folder.
Make sure you choose the correct class estimators/transformers and namespace.
Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
Make sure the DocTable points to correct API link.
Navigate to website folder, and run yarn run start to make sure the website renders correctly.
Don't forget to add  before each python code blocks to enable auto-tests for python samples.
Make sure the WebsiteSamplesTests job pass in the pipeline.

azure-pipelines · 2026-04-14T21:04:51Z

Azure Pipelines: 1 pipeline(s) require an authorized user to comment /azp run to run.

smamindl · 2026-04-14T21:05:57Z

/azp run

azure-pipelines · 2026-04-14T21:06:08Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a PR-validation CI job intended to detect whether release branches (starting with spark4.0) can be cleanly rebased onto the PR head and still compile.

Changes:

Introduces a ReleaseBranchCompat job that fetches a release branch, attempts a rebase onto the PR head, and then runs sbt compile test:compile.
Uses a matrix strategy to make it easy to add more release branches.
Marks the job as non-blocking via continueOnError: true.

Copilot · 2026-04-14T21:11:19Z

+        git checkout FETCH_HEAD
+        git rebase --onto HEAD $MASTER_BASE 2>&1 || {


git rebase --onto HEAD ... is using HEAD after git checkout FETCH_HEAD, so HEAD now points to the release branch tip rather than the PR head. This makes the rebase target incorrect (effectively rebasing onto the release tip). Capture the PR head commit hash before switching to FETCH_HEAD (e.g., PR_HEAD=$(git rev-parse HEAD)) and use that in --onto (git rebase --onto $PR_HEAD $MASTER_BASE).

Copilot · 2026-04-14T21:11:19Z

+    - task: AzureCLI@2
+      displayName: 'Compile $(RELEASE_BRANCH) after rebase'
+      timeoutInMinutes: 20
+      inputs:
+        azureSubscription: 'SynapseML Build'
+        scriptLocation: inlineScript
+        scriptType: bash
+        inlineScript: |


This compile step uses AzureCLI@2 with a service connection (azureSubscription), even though the script only runs sbt. For PR validation—especially from forks—service connections are typically unavailable and can also increase secret-exposure risk. Use a plain script task (e.g., Bash@3) for the sbt invocation, or add a condition to skip this task when the PR is from a fork (e.g., based on System.PullRequest.IsFork).

Suggested change

- task: AzureCLI@2

displayName: 'Compile $(RELEASE_BRANCH) after rebase'

timeoutInMinutes: 20

inputs:

azureSubscription: 'SynapseML Build'

scriptLocation: inlineScript

scriptType: bash

inlineScript: |

- task: Bash@3

displayName: 'Compile $(RELEASE_BRANCH) after rebase'

timeoutInMinutes: 20

inputs:

targetType: inline

script: |

Copilot · 2026-04-14T21:11:19Z

+        inlineScript: |
+          set -e
+          export SBT_OPTS="-Xmx4G -Xss2M -Duser.timezone=GMT"
+          echo "=== Compiling $(RELEASE_BRANCH) rebased onto PR HEAD ==="
+          sbt compile test:compile
+          echo "##vso[task.logissue type=info]$(RELEASE_BRANCH) compiles successfully after rebase"


PR description says "Reports merge conflicts and compile failures as warnings", but compile failures here will fail the task without emitting a type=warning logissue (only success emits type=info). If you want failures to be reported as warnings, catch sbt non-zero exit and log ##vso[task.logissue type=warning]... before exiting non-zero (or set continueOnError: true on this task and explicitly log the warning on failure).

codecov-commenter · 2026-04-14T21:20:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.30%. Comparing base (a833941) to head (bcad72b).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
- Coverage   84.70%   82.30%   -2.40%     
==========================================
  Files         335      335              
  Lines       17753    17753              
  Branches     1615     1615              
==========================================
- Hits        15037    14611     -426     
- Misses       2716     3142     +426

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

azure-pipelines · 2026-04-14T21:37:22Z

Azure Pipelines: 1 pipeline(s) require an authorized user to comment /azp run to run.

smamindl · 2026-04-14T21:40:23Z

/azp run

azure-pipelines · 2026-04-14T21:40:34Z

Azure Pipelines: Successfully started running 1 pipeline(s).

github-actions · 2026-04-14T22:13:38Z

Hey @smamindl 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

fix: Fix LightGBM crashes with empty partitions
feat: Make HTTP on Spark back-offs configurable
docs: Update Spark Serving usage
build: Add codecov support
perf: improve LightGBM memory usage
refactor: make python code generation rely on classes
style: Remove nulls from CNTKModel
test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

azure-pipelines · 2026-04-14T22:40:57Z

Azure Pipelines: 1 pipeline(s) require an authorized user to comment /azp run to run.

smamindl · 2026-04-14T22:41:59Z

/azp run

azure-pipelines · 2026-04-14T22:42:10Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Add a ReleaseBranchCompat job that runs on every PR to master. It rebases each release branch (starting with spark4.0) onto the PR HEAD and runs sbt compile test:compile to catch breakage before it lands in master. - Non-blocking (continueOnError: true) - Matrix-based for easy expansion to more release branches - Reports merge conflicts and compile failures as warnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

azure-pipelines · 2026-04-14T23:31:23Z

Azure Pipelines: 1 pipeline(s) require an authorized user to comment /azp run to run.

smamindl · 2026-04-14T23:32:07Z

/azp run

azure-pipelines · 2026-04-14T23:32:19Z

Azure Pipelines: Successfully started running 1 pipeline(s).

Copilot AI review requested due to automatic review settings April 14, 2026 21:04

Copilot AI reviewed Apr 14, 2026

View reviewed changes

smamindl force-pushed the smamindl/release-branch-compat branch from 56b0c9e to 3c33dca Compare April 14, 2026 21:37

smamindl force-pushed the smamindl/release-branch-compat branch from 3c33dca to 2faa481 Compare April 14, 2026 22:40

Copilot started reviewing on behalf of smamindl April 14, 2026 23:29 View session

smamindl force-pushed the smamindl/release-branch-compat branch from 2faa481 to bcad72b Compare April 14, 2026 23:31

smamindl closed this Apr 15, 2026

		git checkout FETCH_HEAD
		git rebase --onto HEAD $MASTER_BASE 2>&1 \|\| {

Conversation

smamindl commented Apr 14, 2026

Related Issues/PRs

What changes are proposed in this pull request?

How is this patch tested?

Does this PR change any dependencies?

Does this PR add a new feature? If so, have you added samples on website?

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

smamindl commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

smamindl commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

github-actions Bot commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

smamindl commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

smamindl commented Apr 14, 2026

Uh oh!

azure-pipelines Bot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Apr 14, 2026 •

edited

Loading