MAINT: Remove additional initializer persistence - #2525
Merged
Behnam (behnam-o) merged 7 commits intoSep 2, 2026
Merged
Conversation
Behnam (behnam-o)
force-pushed
the
behnam-o-remove-additional-initializers
branch
from
September 1, 2026 19:24
2a32dea to
12f83e0
Compare
Richard Lundeen (rlundeen2)
approved these changes
Sep 1, 2026
Richard Lundeen (rlundeen2)
left a comment
Contributor
There was a problem hiding this comment.
looks great! only nits
Use .pyrit_conf as the single source for configured initializer startup behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Remove assertions for the deleted settings mutation routes after rebasing onto the config editor changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Show configured initializers as a read-only Configuration tab and remove the runtime apply path so initializer execution remains a startup concern. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Handle the configuration request now made before opening the initializer tab. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Keep the unrelated additional information wording unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Keep the Scenario navigation assertion while removing the obsolete standalone Initializers entry. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Behnam (behnam-o)
force-pushed
the
behnam-o-remove-additional-initializers
branch
from
September 1, 2026 22:21
dca04a5 to
5643f5b
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 348ff2fc-5014-444c-a6bc-d306afa6821c
Behnam (behnam-o)
deleted the
behnam-o-remove-additional-initializers
branch
September 2, 2026 00:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using both
.pyrit_confand database-backed additional initializers created two sources of truth for which initializers run in a backend. This removes the additional-initializer path so startup configuration comes only from.pyrit_conf, while keeping the GUI as a read-only view of that configuration.Moved the "configured initializers" as a read-only tab under config. We can potentially expand on this and allow admins to edit pyrit_conf without modifying text directly and instead through some web UI to reduce human errors.
