MAINT Decompose scorer execution policy and result finalization - #2470
Closed
Haseeb Nazir (iamhaseebn) wants to merge 2 commits into
Closed
MAINT Decompose scorer execution policy and result finalization#2470Haseeb Nazir (iamhaseebn) wants to merge 2 commits into
Haseeb Nazir (iamhaseebn) wants to merge 2 commits into
Conversation
Signed-off-by: Haseeb Nazir <36381672+iamhaseebn@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
Preserve the message scorer preparation, execution, and finalization split across the current scorer model and capability architecture. Signed-off-by: Haseeb Nazir <36381672+iamhaseebn@users.noreply.github.com>
Contributor
|
Haseeb Nazir (@iamhaseebn) this is a good change, but I have a similarly stacked PR to progress with this. They do similar things and right now the conflicts aren't worth it. I'd wait at least a month before looking into non-bug scoring refactor changes. Thanks for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MessageScorercurrently handles message substitution, skipping, objective inference, execution errors, fallbacks, and evidence anchoring in one flow. This separates that work into preparation, execution, and finalization steps while keeping the policy in the scorer layer.The branch has also been brought onto current
main. The conflict resolution preserves the newer scorer architecture: capability-based role handling and undetermined results remain inMessageScorer, while shared score validation and persistence remain inScorerand occur exactly once.The refactor preserves behavior for structured refusals, blocked partial content, role and error filtering, explicit and inferred objectives, scorer-owned blocked responses, exception propagation, fallback scores, ephemeral links, persisted evidence, and downstream callers.
Closes #2413.
Tests and Documentation
No documentation changes are needed because this is an internal refactor with no public API or intended behavior changes.