Fix payload truncation, client-secret auth, run pagination, and add architecture diagram#28
Merged
Merged
Conversation
1961e3c to
e20080f
Compare
eoindoherty1
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch contains four commits that together fix a Purview API payload bug, correct the client-secret
action input wiring, cap workflow run pagination, and add a high-level architecture diagram to the setup
guide.
Commits
1.
Fix truncation bug(9677245)Fixes a payload truncation issue in
src/api/purviewClient.tswhere outbound Purview requests were beingcut off. Simplified the size-enforcement path so payloads are constructed and sent intact.
src/api/purviewClient.tsdist/index.js(rebuilt)2.
Update client-secret to use correct parameter(13e5aed)Wires the
client-secretaction input through correctly so client-secret authentication actually worksend-to-end.
action.yml— declares theclient-secretinputsrc/validation/inputValidator.ts+ tests — validation updated to matchInstructions.md,README.md,sample/— docs and sample workflow updated to reference the correctinput name
dist/index.js(rebuilt)3.
Max limit for finding the last run(450e549)Caps the GitHub Actions run-history lookup in
gitHubActionsRunner.tsso first-run detection doesn'tpaginate unbounded against the Actions API.
src/runner/gitHubActionsRunner.tsdist/index.js(rebuilt)4.
Add overall Image for Instructions.md(e20080f)Adds an Architecture Overview section near the top of
Instructions.mdwith a Mermaidflowchart LRdiagram (renders natively on GitHub) showing the three systems being wired together — GitHub (target
repo, workflow repo, action, org secrets, ruleset), Microsoft Entra ID (app registration), and
Microsoft Purview — plus a short bulleted recap of the four things a user configures across the guide
and a one-sentence runtime summary.
Instructions.mdWhy
files.
asked to create app registrations, secrets, and rulesets.
Test notes
inputValidatortests updated for the renamed parameter.dist/rebuilt for each code change.