Merged
Conversation
This PR fixes the issue of how natvis matches which multi-templated arguments. E.g. <*> would be selected over <*, *, *>. This now will pick the first highest templated argument count, but also FindBestMatch to prefer concrete template args over wildcards at the same arg count. E.g. If you had natvis for <*, *> and are visualizing <*, *, *, *> you will get the <*, *> view. There was also an issue with expression substitution to skip identifiers preceded by member-access operators (., ->, ::) so that sub-expressions like "ptr->member" are not incorrectly replaced with root-level lookups Added tests.
gregg-miskelly
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of how natvis matches which multi-templated arguments.
E.g. <> would be selected over <, *, *>.
This now will pick the first highest templated argument count but also prefer concrete template args over wildcards at the same arg count.
E.g. If you had natvis for <*, > and are visualizing <, *, *, > you will get the <, *> view.
There was also an issue with expression substitution to skip identifiers preceded by member-access operators (., ->, ::) so that sub-expressions like "ptr->member" are not incorrectly replaced with root-level lookups
Added tests.
Addresses #1162