Skip to content

build: initialize hk git hook manager with biome format#26649

Open
tylerbutler wants to merge 4 commits intomicrosoft:mainfrom
tylerbutler:add-hk-hooks
Open

build: initialize hk git hook manager with biome format#26649
tylerbutler wants to merge 4 commits intomicrosoft:mainfrom
tylerbutler:add-hk-hooks

Conversation

@tylerbutler
Copy link
Member

Summary

  • Adds hk.pkl configuration to initialize the hk git hook manager
  • Configures a biome-format pre-commit hook that auto-formats staged files using biome format --write and re-stages the results
  • Extends the built-in Builtins.biome step with format-only commands (no linting)

Add hk.pkl config with a biome-format pre-commit hook that
auto-formats staged JS/TS/JSON files and re-stages the results.
Copilot AI review requested due to automatic review settings March 4, 2026 23:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an hk.pkl configuration at the repo root to adopt the hk git hook manager, with a pre-commit Biome formatting step intended to auto-format staged files and re-stage the results.

Changes:

  • Added hk.pkl extending hk’s built-in configuration and importing hk builtins.
  • Defined a biome-format step and wired it into pre-commit, plus fix and check hooks.

You can also share your feedback on Copilot code review. Take the survey.

tylerbutler and others added 2 commits March 4, 2026 16:07
@tylerbutler tylerbutler requested a review from a team March 5, 2026 00:30
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  257792 links
    1822 destination URLs
    2063 URLs ignored
       0 warnings
       0 errors


Copy link
Contributor

@alexvy86 alexvy86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to approve this blindly just because HK has a sea-shanty 😆 .

I feel a bit conflicted about the additional toolset required for this (more things that people (might) need to know to work on the repo), but being opt-in mitigates that somewhat. Should we consider this an "experimental" thing in the repo for now, and eventually graduate it to a formal "this is a tool we're fully committed to leveraging/supporting" (even if it's still opt-in)? I think that's my main piece of feedback, I'd personally would go with docs (and comments in the pk1 file) that suggest that vs "in this repo we use X".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants