build: initialize hk git hook manager with biome format#26649
build: initialize hk git hook manager with biome format#26649tylerbutler wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Add hk.pkl config with a biome-format pre-commit hook that auto-formats staged JS/TS/JSON files and re-stages the results.
There was a problem hiding this comment.
Pull request overview
This PR introduces an hk.pkl configuration at the repo root to adopt the hk git hook manager, with a pre-commit Biome formatting step intended to auto-format staged files and re-stage the results.
Changes:
- Added
hk.pklextending hk’s built-in configuration and importing hk builtins. - Defined a
biome-formatstep and wired it intopre-commit, plusfixandcheckhooks.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <[email protected]>
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
alexvy86
left a comment
There was a problem hiding this comment.
I'm tempted to approve this blindly just because HK has a sea-shanty 😆 .
I feel a bit conflicted about the additional toolset required for this (more things that people (might) need to know to work on the repo), but being opt-in mitigates that somewhat. Should we consider this an "experimental" thing in the repo for now, and eventually graduate it to a formal "this is a tool we're fully committed to leveraging/supporting" (even if it's still opt-in)? I think that's my main piece of feedback, I'd personally would go with docs (and comments in the pk1 file) that suggest that vs "in this repo we use X".
Summary
hk.pklconfiguration to initialize the hk git hook managerbiome-formatpre-commit hook that auto-formats staged files usingbiome format --writeand re-stages the resultsBuiltins.biomestep with format-only commands (no linting)