Stop AL-Go from purging non AL-Go BC containers.#1828
Draft
spetersenms wants to merge 15 commits intomicrosoft:mainfrom
Draft
Stop AL-Go from purging non AL-Go BC containers.#1828spetersenms wants to merge 15 commits intomicrosoft:mainfrom
spetersenms wants to merge 15 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
This PR on the navcontainerhelper side, adds the functionaltiy to check for the AL-Go creator label: microsoft/navcontainerhelper#3983 |
mazhelez
reviewed
Jul 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents AL-Go from purging non-AL-Go Business Central containers during CICD workflows by adding container labeling and selective flushing logic. The change addresses an issue where AL-Go was removing BC containers created by other development processes on self-hosted runners.
Key changes:
- Modified container creation to add "creator=AL-Go" label to AL-Go containers
- Added conditional logic to only purge AL-Go containers unless custom container creation is used
- Moved the cache flushing operation to occur after container configuration
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the CICD workflow, AL-Go calls https://github.com/microsoft/navcontainerhelper/blob/main/ContainerHandling/Flush-ContainerHelperCache.ps1, which kills any BC container that has been off for 3 days or more, regardless if that container was created by AL-Go.
This scenario can happen if you use self-hosted GitHub runners on the same machine/VM that you use for other BC development.
Related to issue: #1675