Repository navigation
Fix CI: rustfmt, clippy and cargo-deny - #430
Merged
Merged
Conversation
- Apply the latest nightly rustfmt (comment wrapping under `wrap_comments = true`) - Fix clippy lints: explicit_counter_loop and a redundant format! reference in the test vector parser, and some_filter (new in clippy 1.99) in the SIGMA-I transcript builder (`cond.then_some(x)`, same behavior) - Allow clippy::multiple_crate_versions: a fresh resolve pulls in both syn 2 and syn 3 through proc-macro dependencies, which fails the clippy::cargo lint group - Upgrade the cryptoki dev-dependency to 0.12.1 to address RUSTSEC-2026-0286 (used only by the HSM integration test) - Temporarily ignore RUSTSEC-2026-0387 (crypto-bigint 0.5 via elliptic-curve 0.13) in deny.toml. There is no patched 0.5.x; the real fix is the elliptic-curve 0.14 migration, which should remove this ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently failing on
mainfor every PR (e.g. #427), independent of the change being proposed. This fixes those failures:wrap_comments = true. Applied it (comment-only changes).explicit_counter_loopand a redundantformat!reference in the test vector parser.some_filter(new in clippy 1.99) in the SIGMA-I transcript builder:Some(x).filter(|_| cond)->cond.then_some(x). The values have no side effects, so behavior is identical.multiple_crate_versions: a fresh resolve pulls in both syn 2 (via zeroize_derive) and syn 3 (via derive-where, displaydoc, serde_derive), which trips theclippy::cargogroup. It's entirely transitive, so it's allowed inlib.rs, as it was before 2022.cryptokidev-dependency 0.9 -> 0.12.1 for RUSTSEC-2026-0286 (only used by the SoftHSM integration test; small API updates intests/remote_key.rs).No functional changes. No changes to opaque-ke's own dependencies (cryptoki is dev-only).
Verified locally: nightly
cargo fmt --check; clippy with-D warningson stable 1.99.1 and 1.87.0, with and without--cfg test_hsm; rustdoc with-D warnings;taplo fmt --check;cargo deny check; the full CI test matrix (7 backends x 3 frontends, with and withoutstd) on stable and 1.87.0; the wasm32/thumbv6m no_std builds; and bench compilation. I couldn't run the SoftHSM tests locally (compile-only), so CI's HSM run is the real check fortests/remote_key.rs.Companion PR for voprf: meta/voprf#160.