Add optional Hugging Face .tok tokenizer backend - #212
Draft
JacobSzwejbka wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tokinference backend behindTOKENIZERS_BUILD_HF_RUST_TOKENIZER=OFFtokenizers::Tokenizerinterface astokenizers::hf_rust_tokenizertk-encodeandtk-serializationcratesThe format and parser-free runtime come from Hugging Face Tokenizers PR #2352 and the associated
feat/tok-formatwork. A follow-up ExecuTorch change will advance this submodule and opt into the target only when requested.Binary-size behavior
The option is disabled by default. In that configuration CMake does not enter the Rust directory, look for Cargo, compile the bridge, or add either archive, so the default tokenizer binary has a 0-byte delta.
Measured opt-in Apple arm64 artifacts with the size profile:
.tokC++/Rust bridgeValidation
cargo fmt --checkcargo clippy --locked --tests -- -D warningscargo test --locked(3 tests)PATH-Os -fno-exceptions -fno-rtti -Wall -Werrortokenizer.jsonconverted to.tok, then loaded for encode, token lookup, and incremental decodefind_package(tokenizers CONFIG REQUIRED)Current scope
This draft supports host CMake builds. Android, Apple framework, WASM, and Buck packaging still require explicit Rust target/toolchain integration.