Skip to content

Comments

Expand the fallback strategies#1389

Merged
meeb merged 13 commits intomainfrom
issue/1344/fallback-and-matching
Feb 24, 2026
Merged

Expand the fallback strategies#1389
meeb merged 13 commits intomainfrom
issue/1344/fallback-and-matching

Conversation

@tcely
Copy link
Collaborator

@tcely tcely commented Feb 18, 2026 •
edited
Loading

Testing:

docker pull ghcr.io/meeb/tubesync:test@sha256:44d3e489c142c536670cea4ca0d3d00ae2b7e262af9e0e7b3fb6237ebd8a6fa7

To-do list:

  • Migrate sources from NEXT_BEST (n) to NEXT_BEST_CODEC (c) Matched the letter code instead.
  • Review tubesync/sync/matching.py
  • Add the migration for altering Source.
  • Add some tests to verify each option.

Fixes #1344
Fixes #926

@tcely tcely moved this to Todo in Status Feb 18, 2026
@tcely tcely marked this pull request as ready for review February 18, 2026 14:45
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from adb71f4 to 0e6153f Compare February 18, 2026 14:50
@tcely tcely requested a review from meeb February 18, 2026 14:57
meeb
meeb reviewed Feb 18, 2026
View reviewed changes
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch 3 times, most recently from b73003e to 8cc8dde Compare February 19, 2026 09:02
@meeb
Copy link
Owner

meeb commented Feb 19, 2026

Seems fine to me, awesome! Anything else you want to add or is this ready?

@tcely
Copy link
Collaborator Author

tcely commented Feb 19, 2026

I haven't reviewed the matching carefully yet. We should also test these selections do what they claim.

@tcely tcely added the help wanted Extra attention is needed label Feb 19, 2026
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from 8cc8dde to 8223576 Compare February 19, 2026 15:27
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from 8223576 to 1a82983 Compare February 20, 2026 04:41
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from d36b993 to c9c2473 Compare February 20, 2026 06:52
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from c9c2473 to f0e63c5 Compare February 20, 2026 07:07
@tcely tcely requested a review from meeb February 20, 2026 07:37
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch 9 times, most recently from 90d1340 to 76ffe8e Compare February 20, 2026 16:54
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from 4d5601b to 06fd21e Compare February 20, 2026 17:21
@tcely tcely moved this from Todo to Ready in Status Feb 20, 2026
@tcely tcely self-assigned this Feb 20, 2026
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch 5 times, most recently from 7459a4a to 52f74af Compare February 21, 2026 00:00
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch 14 times, most recently from 700ba77 to a7c6c18 Compare February 23, 2026 14:23
@tcely tcely force-pushed the issue/1344/fallback-and-matching branch from a7c6c18 to 38eae54 Compare February 23, 2026 16:25
meeb
meeb approved these changes Feb 24, 2026
View reviewed changes
Copy link
Owner

@meeb meeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@meeb meeb merged commit cc3a185 into main Feb 24, 2026
6 checks passed
@meeb meeb deleted the issue/1344/fallback-and-matching branch February 24, 2026 11:00
@github-project-automation github-project-automation bot moved this from Ready to Done in Status Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meeb meeb meeb approved these changes

Assignees

@tcely tcely

Labels

help wanted Extra attention is needed

Projects

Status
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get_best_video_format falls back to low resolution of requested codec Add AV1 to tests

2 participants

@tcely @meeb