Minor instrument and comp updates, McStas#2332
Merged
willend merged 8 commits intomccode-dev:mainfrom Feb 21, 2026
Merged
Conversation
issues in e.g. instr.show_diagram(analysis=True)
…sues in e.g. instr.show_diagram(analysis=True)
…sues in e.g. instr.show_diagram(analysis=True)
…sues in e.g. instr.show_diagram(analysis=True)
willend
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
%Example definition lines enabling tests for
Doc header rectification in ESS/HZB V20 Test instrument
In source components, make target_index=+1 -> target_index=1 since mcstas-pygen -> McStasscript may experience issues in e.g. instr.show_diagram(analysis=True=)
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!) (FZJ_BenchmarkSfin2 is in fact not reasonable… Deserves an overhaul…)mctestutility to test the instrument (please attachmcviewtestreport as screenshot in comments)