Skip to content

fix: ignore text entered into search bar when compositing #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbnuqw merged 1 commit into from
Sep 4, 2026
Merged

fix: ignore text entered into search bar when compositing #2450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sidebar/components/bar.search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,14 @@ function onKD(e: KeyboardEvent): void {
}
}

function onInput(e: Event) {
function onInput(e: InputEvent) {
// Ignore text entered during composition, before the real text is committed.
// For example, when using an Input Method Editor for typing Japanese, you enter temporary
// latin characters that you convert into the appropriate kanas or kanjis, and then validate.
// Also, on some systems, the usual dead keys work like that.
// https://developer.mozilla.org/en-US/docs/Web/API/InputEvent/isComposing
if (e.isComposing) return

const rawQuery = (e.target as HTMLInputElement | null)?.value ?? ''

if (Settings.state.searchInputTimeout > 0) {
Expand Down