dev-site precious workflow on PR merge works#1568
Conversation
Summary of ChangesHello @mm-jpoole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a linting issue that arose from a recent configuration update. It ensures that a specific Markdown file now adheres to the new formatting standards, preventing automated checks from failing during the merge process. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request applies automated formatting changes to a Markdown file, content/geoip/geolocate-an-ip/client-side-javascript.md. The modifications adjust the column widths within a Markdown table to align with the project's linting rules. These changes are purely stylistic and do not alter the content. The update is correct and helps maintain code consistency.
to ensure html inside client-side-javascript.md is correctly formatted. Previously, only the nested <p> tag matched, leading to incorrect indentation. This is a unique .md file because it contains html but no {{< rawhtml >}} tag, but rather a md html code block. This is a simple fix that doesn't seem to cause any problems.
now he's with his friends in bin/ and as an added bonus he will actually be linted by the precious prettier-scripts command
it wasn't being tidied previously due to it's previous directory not being included by the precious prettier-scripts command
mm-jpoole
force-pushed
the
jpoole/format-single-file
branch
from
1458fc0 to
7e45c54
Compare
Deploying dev-site with
|
| Latest commit: |
7e45c54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bc742bb7.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://jpoole-format-single-file.dev-site-4ua.pages.dev |
dhogan8
left a comment
dhogan8
left a comment
There was a problem hiding this comment.
🔥🔥, thank you for catching this!
2 participants
https://linear.app/maxmind/issue/SCO-8489/dev-site-precious-workflow-on-pr-merge-works
Unfortunately prettier-markdown and format-content are still fighting each other, now over a single file.
After #1566 PR merged into main, the precious workflow runs on all files and it failed on content/geoip/geolocate-an-ip/client-side-javascript.md
Something wacky is going on here and it is breaking the
precious lint --allworkflow that runs on main after PRs are merged. I'll figure out why this one file always fails linting, even after tidying.ac