Skip to content

refactor: remove build.rs and runtime resource copying at build time - #171

Merged
philocalyst merged 1 commit into
max-niederman:mainfrom
qaqland:main
Mar 24, 2026
Merged

refactor: remove build.rs and runtime resource copying at build time#171
philocalyst merged 1 commit into
max-niederman:mainfrom
qaqland:main

Conversation

@qaqland

@qaqland qaqland commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

Ref 65ffea7

@philocalyst

Copy link
Copy Markdown
Collaborator

Sorry, why do you think we should remove this entirely? Pretty good fallback at pretty low cost imo @qaqland

@qaqland

qaqland commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Usually, build.rs are meant to help with compilation only and shouldn't touch user configuration directories.

OUT_DIR — If the package has a build script, this is set to the folder where the build script should place its output. See below for more information. (Only set during compilation.) Cargo does not guarantee that this directory is empty, and it is not cleaned between builds.
https://doc.rust-lang.org/cargo/reference/environment-variables.html

@philocalyst

Copy link
Copy Markdown
Collaborator

Thanks for the clarification, just didn't know the intent here. We'll make sure this is handled on the packaging side.

@philocalyst philocalyst self-assigned this Mar 24, 2026
@philocalyst
philocalyst self-requested a review March 24, 2026 02:23

@philocalyst philocalyst left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philocalyst
philocalyst merged commit 4fa78e6 into max-niederman:main Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants