Skip to content

Fix CMake 4.0+ generation error - #15

Open
Dove6 wants to merge 1 commit into
mavenlin:masterfrom
Dove6:fix-cmake-error-no-minimum-version
Open

Dove6 wants to merge 1 commit into
mavenlin:masterfrom
Dove6:fix-cmake-error-no-minimum-version

Conversation

@Dove6

@Dove6 Dove6 commented Jan 8, 2026

Copy link
Copy Markdown

Starting with CMake 4.0, an error is thrown if there is no minimum version specified:

https://cmake.org/cmake/help/latest/policy/CMP0000.html#policy:CMP0000

I've set to to 3.10, because a) it cannot be set lower than 3.5 b) support for versions below 3.10 is going to be cut soon according to a warning.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Dove6, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a build issue encountered with CMake versions 4.0 and later by introducing a mandatory minimum version declaration into the CMake template. This change ensures that projects built with this template remain compatible with modern CMake practices, preventing build failures and aligning with future deprecation policies for older CMake versions.

Highlights

  • CMake Compatibility Fix: Addresses a build generation error that occurs with CMake versions 4.0 and newer, which now require an explicit minimum version to be specified.
  • Minimum Version Set: The cmake_minimum_required version has been set to 3.10. This version was chosen as it's above the lowest supported 3.5 and preemptively handles warnings about upcoming deprecation for versions below 3.10.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a compatibility issue with modern CMake versions by adding the cmake_minimum_required(VERSION 3.10) directive to the cmake_template. This change is necessary to prevent build failures, as newer CMake versions require the minimum version to be specified. The choice of version 3.10 is reasonable and well-justified in the pull request description. The implementation is correct and follows best practices. The change is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant