Implement NSCache to cache MLX ModelContext #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mattt could you please take a look at this? I tested the PR with https://github.com/mattt/chat-ui-swift and I’m seeing an issue with conversation history handling. The model appears to be responding to the previous (n-1) prompt rather than the latest one, which suggests the chat state may be getting out of sync somewhere. Though cache seems to be working fine. |
Owner
|
@noorbhatia Oh, nice. Thank you for opening this PR in response to the issue you filed earlier. I'm wrapping up work on a Swift implementation of Xet. Once I cut that initial release, I'll take a look at this next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a simple caching for MLXLanguage
A possible solution for #89