Skip to content

Update CreatePost to handle when missing RootId #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hloeung merged 4 commits into from
Aug 18, 2026
Merged

Update CreatePost to handle when missing RootId #79

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0316f90
Update CreatePost to handle when missing RootId
hloeung Aug 18, 2026
8ea5fbd
golangci-lint fixes
hloeung Aug 18, 2026
1ab089d
Merge branch 'master' into fixes
hloeung Aug 18, 2026
a5f6b96
Refactor post caching condition in CreatePost
hloeung Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions messages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/hex"
"encoding/json"
"errors"
"net/http"
"strconv"
"strings"

Expand All @@ -22,9 +23,21 @@ func (m *Client) parseResponse(rmsg *model.WebSocketResponse) {
}

func (m *Client) CreatePost(ctx context.Context, post *model.Post) (*model.Post, error) {
if post.UserId == "" && m.User != nil {
post.UserId = m.User.Id
}

// Proactive RootId resolution: if RootId points to a reply, flatten to root post
if post.RootId != "" && m.postCache != nil {
if cached, ok := m.postCache.Get(post.RootId); ok && cached.RootId != "" {
post.RootId = cached.RootId
}
}

retryCount := 0
for {
m.apiLogger.Warnf("CreatePost: UserID: %s, ChannelID: %s #%d", post.UserId, post.ChannelId, retryCount)

res, resp, err := m.Client.CreatePost(ctx, post)
if err == nil {
if m.postCache != nil {
Expand All @@ -34,6 +47,15 @@ func (m *Client) CreatePost(ctx context.Context, post *model.Post) (*model.Post,
return res, nil
}

// Reactive RootId resolution: if the API rejected it because RootId wasn't the root post
if post.RootId != "" && resp != nil && resp.StatusCode == http.StatusBadRequest {
rootPost, gErr := m.GetPost(ctx, post.RootId)
if gErr == nil && rootPost.RootId != "" {
post.RootId = rootPost.RootId
continue
}
}

shouldRetry, hErr := m.HandleRetry(ctx, "CreatePost", err, retryCount, 10, resp)
if hErr == nil && shouldRetry {
retryCount++
Expand Down