Skip to content

ci: remove obsolete merge MOC update workflow - #26251

Merged
XuPeng-SH merged 11 commits into
mainfrom
ci/remove-obsolete-merge-update-moc
Jul 27, 2026
Merged

ci: remove obsolete merge MOC update workflow#26251
XuPeng-SH merged 11 commits into
mainfrom
ci/remove-obsolete-merge-update-moc

Conversation

@XuPeng-SH

@XuPeng-SH XuPeng-SH commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the obsolete post-merge MOC coverage-status workflow. The current coverage pipeline is self-contained and no longer creates the legacy MOC record this workflow expects.
  • Stabilize three user-level-lock cleanup tests by asserting durable terminal state instead of transient asynchronous-worker ownership/progress, and always reset shared test state on early assertion exit.
  • Add the read-only mo-pr-radar skill for deterministic PR review queues, conflict/CI/approval filters, request-changes freshness, and per-PR blocker explanations. Its review model uses each reviewer's latest opinionated review, so a later comment cannot erase an approval/change request and a later approval clears historical change requests.
  • Strengthen mo-self-review with exact affected-test selection, adaptive per-test race budgets, deterministic flake checks, and one complete owning-package race run. Zero/under-resolution JSON test durations safely use the adaptive ceiling.

Validation

  • Confirmed the removed workflow runs only after a merged PR closes, is not a required check on main or 4.2-dev, and has no repository/Mergify references.
  • PR radar: 22 offline unit tests, Bash syntax checks, both skill validators, and live GitHub regressions: fix(replace): apply parent-side foreign key actions during REPLACE #25089 remains CHANGES_REQUESTED after a later comment; approved fix(logtail): propagate checkpoint iterator errors #26233 is absent from the stale-change queue.
  • Adaptive race measurements from go test -json, with B=30s: release-cleanup T=0.07s, N=100; timed-out cleanup T=1.06s, N=28; successful-probe cleanup T=0.05s, N=100.
  • Final focused race stress passed for all three exact tests (-count=100/28/100); matching non-race stress also passed.
  • Full pkg/sql/plan/function owning package passed with -race -count=1.
  • go build and go vet passed for pkg/sql/plan/function.
  • git diff --check passed after merging the latest main.

Fixes #26262.
Related to #26253.

@XuPeng-SH
XuPeng-SH requested a review from fengttt as a code owner July 27, 2026 11:45
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Jul 27, 2026
@XuPeng-SH
XuPeng-SH requested a review from aunjgr as a code owner July 27, 2026 16:02
@matrix-meow matrix-meow added size/L Denotes a PR that changes [500,999] lines and removed size/S Denotes a PR that changes [10,99] lines labels Jul 27, 2026
@matrix-meow matrix-meow added size/M Denotes a PR that changes [100,499] lines and removed size/XL Denotes a PR that changes [1000, 1999] lines labels Jul 27, 2026
@XuPeng-SH
XuPeng-SH merged commit 7efe365 into main Jul 27, 2026
28 of 29 checks passed
@XuPeng-SH
XuPeng-SH deleted the ci/remove-obsolete-merge-update-moc branch July 27, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes [100,499] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: flaky user-level lock cleanup test in coverage UT

3 participants