feat(data-branch): materialize diff output as table#25863
Draft
gouhongshen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
DATA BRANCH DIFF ... [COLUMNS (...)] OUTPUT AS <table>.CREATE TABLE(or database-wide equivalent) on the destination database.User impact
Diff output can now be retained and queried across sessions. The result table has no
mo_branch_metadatarow and is never treated as a data branch.Validation
mo-cgo-test -race -count=1 -timeout=240s ./pkg/frontend -run 'Test(DataBranchOutput|ValidateDataBranchDiffOutputAs)'go test ./pkg/sql/parsers/dialect/mysql -run 'TestDataBranchDiff(Columns|OutputModes)' -count=1make builddiff_1773/73 and branch privilege 257/257.git4data/branch/diffBVT: 1478/1478 passes with result-set metadata comparison disabled. Strict comparison reports 57 pre-existing metadata-only expectation mismatches indiff_8,diff_9,diff_12,diff_13,diff_14, anddiff_16; every data row matches and the ordinary DIFF output path is unchanged. Those unrelated expected-result updates are intentionally excluded from this PR.