Organize Astra install and release flows#67
Conversation
- Support -b/--binary for astra, astra-server, astra-edge - Same UX: -v, -d, -y, -n, -h flags - ghproxy fallback for mainland China users - sha256 verification, PATH setup, shell detection
aptend
left a comment
There was a problem hiding this comment.
Thanks for putting together the public Astra install / local-stack flow. I agree with the general direction, but I think this PR should not merge in its current shape because it changes the existing gateway install contract.
The main concern is that Astra CLI / Astra server / local stack are optional integrations for gateway, but this PR makes them take over the current public installer entrypoint. Today scripts/install.sh installs astra-gateway, and users or automation may already rely on:
curl -sSL https://raw.githubusercontent.com/matrixorigin/astra-suite/main/scripts/install.sh | shAfter this PR, the same command installs the astra CLI instead. That is a breaking semantic change and also couples gateway users to the Astra CLI release pipeline.
Please keep the gateway path stable and split the optional Astra flows out:
- Keep
scripts/install.shas theastra-gatewayinstaller, preserving current behavior. - If needed, enhance the gateway installer /
astra-gateway updatelogic to resolve component-scoped gateway releases while still supporting legacyv*releases. - Add a separate installer such as
scripts/install-astra.shfor theastraCLI, trackingastra-cli-v*releases andastra-v<version>-<platform>.tar.gzassets. - Keep the local Astra stack under
deployment/astra-stack/or behind a separate stack management script, and document it as optional. - Do not make the README primary flow depend on Astra CLI / MatrixOne / Memoria unless the user explicitly wants a local Astra backend.
There is also a release-readiness issue: current releases in this repo are legacy gateway releases (v0.4.0, v0.3.x, etc.). There is no astra-cli-v* release with astra-v<version>-<platform>.tar.gz assets yet. If scripts/install.sh is switched to the Astra CLI installer before that external release pipeline is ready, the documented default install command will fail immediately after merge.
In short: adding Astra CLI install and local stack support is fine, but it should be fully optional and must not interfere with the existing gateway install/update flow.
|
Addressed the review in cd213e0. Changes made:
Validation run locally:
|
Summary
Validation
Release note
Default CLI install will start working after the private astra repo publishes the first astra-cli-v release into this repo.