-
-
Notifications
You must be signed in to change notification settings - Fork 402
enable linting MD032 separate lists with blank lines #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
HarHarLinks
wants to merge
4
commits into
main
Choose a base branch
from
HarHarLinks/md032
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
this is a draft because rumdl is producing some issues here, e.g. diff --git a/content/blog/2021/11/2021-11-19-this-week-in-matrix-2021-11-19.md b/content/blog/2021/11/2021-11-19-this-week-in-matrix-2021-11-19.md
index d3c16e8a4..e0a82889d 100644
--- a/content/blog/2021/11/2021-11-19-this-week-in-matrix-2021-11-19.md
+++ b/content/blog/2021/11/2021-11-19-this-week-in-matrix-2021-11-19.md
@@ -183,6 +183,7 @@ Desktop client for Matrix using Qt and C++17.
> * Move to the next room with unread messages by pressing `Alt-A`. (Symphorien)
> * Support jdenticons as a placeholder for rooms or users without avatars.
> (LorenDB)
+>
> - You will need to install <https://github.com/Nheko-Reborn/qt-jdenticon>
> * Properly sign macOS builds.
> * Support animated images like GIF and WebP.
@@ -198,6 +199,7 @@ Desktop client for Matrix using Qt and C++17.
> * Render room avatar changes in the timeline. (BShipman)
> * Support pulling out the sidebar to make it wider.
> * Allow editing pending messages instead of blocking until they are sent.
+>
> (balsoft)
> * Support mnemonics in the context menus. (AppAraat)
> * Support TOFU for encryption. (Trust on first use)
diff --git a/content/blog/2024/05/2024-05-24-twim.md b/content/blog/2024/05/2024-05-24-twim.md
index 1f34e529f..ad4661333 100644
--- a/content/blog/2024/05/2024-05-24-twim.md
+++ b/content/blog/2024/05/2024-05-24-twim.md
@@ -113,6 +113,7 @@ Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compo
> many devices as they desire.
> - **Make memberships reliable.** MatrixRTC membership is tracked by room state. Since room state cannot expire, clients need to manually
> update their membership state when they leave. So as soon as the client crashes, loses network, or the user `ctrl+w`'s the call instead of hanging up, the call remains.
+>
> - Currently there is a workaround to store a expire time inside the event, periodically update the event, and check if it's valid before using the membership.
> - **Spec call focus information**, and expose it via the client `.well-known`.
>
diff --git a/content/docs/matrix-concepts/rooms_and_events/_index.md b/content/docs/matrix-concepts/rooms_and_events/_index.md
index 6428e9ed1..01aec6d81 100644
--- a/content/docs/matrix-concepts/rooms_and_events/_index.md
+++ b/content/docs/matrix-concepts/rooms_and_events/_index.md
@@ -123,6 +123,7 @@ ask Alice's `example.com` a local copy of the room, and stay in sync with it.
}}
If Carol joins from her homeserver `ergaster.org`, she will also get the power level
+
0.
{{ figure( |
ecb938e to
a9754db
Compare
Deploying matrix-website with
|
| Latest commit: |
a15f4a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2579f638.matrix-website.pages.dev |
| Branch Preview URL: | https://harharlinks-md032.matrix-website.pages.dev |
Signed-off-by: HarHarLinks <[email protected]>
Signed-off-by: HarHarLinks <[email protected]>
Signed-off-by: HarHarLinks <[email protected]>
Signed-off-by: HarHarLinks <[email protected]>
6dd5a80 to
a15f4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
This would be an improvement to the website.
meta
Something concerning the repo itself, such as technical changes, contribution guidelines, and more.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled MD032 linting rule in rumdl to enforce empty lines around lists.
Changes done with with
rumdl fmtand reviewed by me, plus further fixes (see commits).Related issues
#3058
Role
Website & Content WG
Timeline
Signoff
Please sign off your individual commits or whole pull request.