Merged
Conversation
fzaninotto
reviewed
Dec 10, 2025
Member
|
Why are all the packages.json updated? |
Contributor
Author
Probably my editor, reverting |
ccd5b2b to
22a9fab
Compare
22a9fab to
f545c8d
Compare
fzaninotto
requested changes
Jan 28, 2026
Madeorsk
requested changes
Feb 3, 2026
WiXSL
requested changes
Feb 3, 2026
| if (currentStoreKey.current !== storeKey) { | ||
| // storeKey has changed | ||
| currentStoreKey.current = storeKey; | ||
| return; |
Collaborator
There was a problem hiding this comment.
It should return only if the URL already has params; if it’s empty, we need to sync from the store (when disableSyncWithLocation is false, of course).
if (Object.keys(queryFromLocation).length > 0) {
return;
}
Collaborator
There was a problem hiding this comment.
Mmm, a test is needed for this
Madeorsk
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users are redirected to a list page for which they previously applied some parameters (page, perPage, filters, etc.), they don't see those parameters reflected in the URL even though they are indeed applied on the list. This happens for instance when redirected from an edition page. This makes the URL non shareable anymore and can be surprising.
Fixes #11018
Solution
When the list loads, if there are stored parameters and those are not reflected in the URL, update the URL except if:
disableSyncLocationistrue/posts)How To Test
make runPerformances
nextbranch, repeat the steps above but enable the react profiler (devtool) before clicking Save at step 3. Note the number of renders of theListcomponentAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.